Add helper type QueryRef.ForQuery<TypedDocumentNode>#13012
Merged
phryneas merged 3 commits intorelease-4.1from Nov 14, 2025
Merged
Add helper type QueryRef.ForQuery<TypedDocumentNode>#13012phryneas merged 3 commits intorelease-4.1from
phryneas merged 3 commits intorelease-4.1from
Conversation
🦋 Changeset detectedLatest commit: c51aae0 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
Member
Author
|
CI fails seem to be completely unrelated, merging. |
jerelmiller
pushed a commit
that referenced
this pull request
Nov 17, 2025
* Add helper type `QueryRef.ForQuery<TypedDocumentNode>` * chores
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another small one I came across writing a tutorial. In my demo codebase I find myself doing
with this, it would change like:
import { gql } from "@apollo/client"; import { QueryRef } from "@apollo/client/react"; import { ScheduleScreenDocument } from "./ScheduleScreen.generated"; import { ScheduleList } from "./components/ScheduleList"; import { - ResultOf, VariablesOf } from "@graphql-typed-document-node/core"; if (false) { // eslint-disable-next-line no-unused-expressions gql` query ScheduleScreen($eventId: String!) { ...ScheduleList_event } `; } ScheduleScreen.Query = ScheduleScreenDocument; export function ScheduleScreen({ queryRef, variables, }: { + queryRef: QueryRef.ForQuery<typeof ScheduleScreen.Query> - queryRef: QueryRef< - ResultOf<typeof ScheduleScreen.Query>, - VariablesOf<typeof ScheduleScreen.Query> - >; variables: VariablesOf<typeof ScheduleScreen.Query>; }) { return ( <ScheduleList event={"ROOT_QUERY" as any} queryRef={queryRef} variables={variables} /> ); }It's not a world of difference, but a nice piece of DX and reduces mental overhead.