Skip to content

chore: add @deprecated notice to variableMatcher#12970

Merged
jerelmiller merged 4 commits intoapollographql:version-3.xfrom
acemir:chore/variableMatcher-deprecation-notice
Feb 10, 2026
Merged

chore: add @deprecated notice to variableMatcher#12970
jerelmiller merged 4 commits intoapollographql:version-3.xfrom
acemir:chore/variableMatcher-deprecation-notice

Conversation

@acemir
Copy link
Copy Markdown
Contributor

@acemir acemir commented Oct 13, 2025

variableMatcher was removed from Mocklink.MockedResponse on Apollo Client 4.0

@apollo-cla
Copy link
Copy Markdown

@acemir: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Oct 13, 2025

🦋 Changeset detected

Latest commit: 15729b2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@apollo/client Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@acemir acemir changed the title Add deprecation notice to variableMatcher chore: add deprecation notice to variableMatcher Oct 13, 2025
@acemir acemir force-pushed the chore/variableMatcher-deprecation-notice branch from 9662d8e to 1e02553 Compare October 13, 2025 09:13
@jerelmiller
Copy link
Copy Markdown
Member

Hey @acemir 👋

Appreciate the PR! We'll need to do a bit of work to allow the version-3.x branch to be releasable (we originally planned for 3.14.0 to be the last 3.x change). This change looks ok otherwise! Please be patient with us for a little bit until we can get that in place.

@acemir acemir force-pushed the chore/variableMatcher-deprecation-notice branch from 1e02553 to cc1e467 Compare October 21, 2025 22:33
@acemir acemir requested a review from a team as a code owner October 21, 2025 22:33
@acemir acemir closed this Oct 21, 2025
@acemir acemir force-pushed the chore/variableMatcher-deprecation-notice branch from cc1e467 to cdcd7ed Compare October 21, 2025 22:45
@acemir acemir reopened this Oct 21, 2025
@acemir acemir changed the title chore: add deprecation notice to variableMatcher chore: add @deprecated notice to variableMatcher Oct 22, 2025
@acemir acemir force-pushed the chore/variableMatcher-deprecation-notice branch from 368b50a to 8a730a0 Compare October 22, 2025 02:20
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Oct 22, 2025

npm i https://pkg.pr.new/@apollo/client@12970

commit: 15729b2

`variableMatcher` was removed from `Mocklink.MockedResponse` on Apollo 4.0
@acemir acemir force-pushed the chore/variableMatcher-deprecation-notice branch from 8a730a0 to f6f9ee5 Compare October 22, 2025 07:34
Copy link
Copy Markdown
Member

@jerelmiller jerelmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion for the deprecation message for accuracy. Let's also get a changeset in here so we can get this in a patch release (otherwise this will just sit in that branch)

@jerelmiller jerelmiller merged commit f91fab5 into apollographql:version-3.x Feb 10, 2026
37 checks passed
@github-actions github-actions bot mentioned this pull request Feb 10, 2026
jerelmiller pushed a commit that referenced this pull request Mar 12, 2026
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to version-3.x, this
PR will be updated.


# Releases
## @apollo/[email protected]

### Patch Changes

- [#13168](#13168)
[`6b84ec0`](6b84ec0)
Thanks [@jerelmiller](https://github.com/jerelmiller)! - Fix issue where
muting a deprecation from one entrypoint would not mute the warning when
checked in a different entrypoint. This caused some rogue deprecation
warnings to appear in the console even though the warnings should have
been muted.

- [#12970](#12970)
[`f91fab5`](f91fab5)
Thanks [@acemir](https://github.com/acemir)! - Add a deprecation message
for the `variableMatcher` option in `MockLink`.

- [#13168](#13168)
[`6b84ec0`](6b84ec0)
Thanks [@jerelmiller](https://github.com/jerelmiller)! - Ensure
deprecation warnings are properly silenced in React hooks when globally
disabled.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@jerelmiller jerelmiller mentioned this pull request Mar 12, 2026
jerelmiller added a commit that referenced this pull request Mar 12, 2026
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to version-3.x, this
PR will be updated.


# Releases
## @apollo/[email protected]

### Patch Changes

- [#13168](#13168)
[`6b84ec0`](6b84ec0)
Thanks [@jerelmiller](https://github.com/jerelmiller)! - Fix issue where
muting a deprecation from one entrypoint would not mute the warning when
checked in a different entrypoint. This caused some rogue deprecation
warnings to appear in the console even though the warnings should have
been muted.

- [#12970](#12970)
[`f91fab5`](f91fab5)
Thanks [@acemir](https://github.com/acemir)! - Add a deprecation message
for the `variableMatcher` option in `MockLink`.

- [#13168](#13168)
[`6b84ec0`](6b84ec0)
Thanks [@jerelmiller](https://github.com/jerelmiller)! - Ensure
deprecation warnings are properly silenced in React hooks when globally
disabled.

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Jerel Miller <[email protected]>
@jerelmiller
Copy link
Copy Markdown
Member

Hey @acemir 👋

Thanks so much for your patience! This has now been published in 3.14.1. Appreciate the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants