chore: add @deprecated notice to variableMatcher#12970
chore: add @deprecated notice to variableMatcher#12970jerelmiller merged 4 commits intoapollographql:version-3.xfrom
@deprecated notice to variableMatcher#12970Conversation
|
@acemir: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
🦋 Changeset detectedLatest commit: 15729b2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
variableMatchervariableMatcher
9662d8e to
1e02553
Compare
|
Hey @acemir 👋 Appreciate the PR! We'll need to do a bit of work to allow the |
1e02553 to
cc1e467
Compare
cc1e467 to
cdcd7ed
Compare
variableMatcher@deprecated notice to variableMatcher
368b50a to
8a730a0
Compare
commit: |
`variableMatcher` was removed from `Mocklink.MockedResponse` on Apollo 4.0
8a730a0 to
f6f9ee5
Compare
jerelmiller
left a comment
There was a problem hiding this comment.
One suggestion for the deprecation message for accuracy. Let's also get a changeset in here so we can get this in a patch release (otherwise this will just sit in that branch)
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to version-3.x, this PR will be updated. # Releases ## @apollo/[email protected] ### Patch Changes - [#13168](#13168) [`6b84ec0`](6b84ec0) Thanks [@jerelmiller](https://github.com/jerelmiller)! - Fix issue where muting a deprecation from one entrypoint would not mute the warning when checked in a different entrypoint. This caused some rogue deprecation warnings to appear in the console even though the warnings should have been muted. - [#12970](#12970) [`f91fab5`](f91fab5) Thanks [@acemir](https://github.com/acemir)! - Add a deprecation message for the `variableMatcher` option in `MockLink`. - [#13168](#13168) [`6b84ec0`](6b84ec0) Thanks [@jerelmiller](https://github.com/jerelmiller)! - Ensure deprecation warnings are properly silenced in React hooks when globally disabled. Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to version-3.x, this PR will be updated. # Releases ## @apollo/[email protected] ### Patch Changes - [#13168](#13168) [`6b84ec0`](6b84ec0) Thanks [@jerelmiller](https://github.com/jerelmiller)! - Fix issue where muting a deprecation from one entrypoint would not mute the warning when checked in a different entrypoint. This caused some rogue deprecation warnings to appear in the console even though the warnings should have been muted. - [#12970](#12970) [`f91fab5`](f91fab5) Thanks [@acemir](https://github.com/acemir)! - Add a deprecation message for the `variableMatcher` option in `MockLink`. - [#13168](#13168) [`6b84ec0`](6b84ec0) Thanks [@jerelmiller](https://github.com/jerelmiller)! - Ensure deprecation warnings are properly silenced in React hooks when globally disabled. --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Jerel Miller <[email protected]>
variableMatcherwas removed fromMocklink.MockedResponseon Apollo Client 4.0