`QueryManager.inFlightLinkObservables`: use a strong `Trie` by phryneas · Pull Request #11345 · apollographql/apollo-client

phryneas · 2023-11-06T16:04:31Z

Since @wryware/[email protected] now has a remove function, we can use that data structure in QueryManager.inFlightLinkObservables and shave off a few bytes here.

Should not be merged before we have a new `optimism` version

Before merging/releasing: add handling to `@apollo/experimental-nextjs-app-support`

Checklist:

If this PR contains changes to the library itself (not necessary for e.g. docs updates), please include a changeset (see CONTRIBUTING.md)
If this PR is a new feature, please reference an issue where a consensus about the design was reached (not necessary for small changes)
Make sure all of the significant new logic is covered by tests

changeset-bot · 2023-11-06T16:04:35Z

🦋 Changeset detected

Latest commit: 7fb21fa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@apollo/client	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions · 2023-11-06T16:06:06Z

size-limit report 📦

Path	Size
dist/apollo-client.min.cjs	37.79 KB (+0.16% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs"	44.26 KB (+0.16% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" (production)	42.75 KB (+0.18% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js"	32.87 KB (+0.25% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" (production)	31.55 KB (+0.29% 🔺)
import { ApolloProvider } from "dist/react/index.js"	1.28 KB (0%)
import { ApolloProvider } from "dist/react/index.js" (production)	1.26 KB (0%)
import { useQuery } from "dist/react/index.js"	4.38 KB (0%)
import { useQuery } from "dist/react/index.js" (production)	4.19 KB (0%)
import { useLazyQuery } from "dist/react/index.js"	4.69 KB (0%)
import { useLazyQuery } from "dist/react/index.js" (production)	4.51 KB (0%)
import { useMutation } from "dist/react/index.js"	2.65 KB (0%)
import { useMutation } from "dist/react/index.js" (production)	2.63 KB (0%)
import { useSubscription } from "dist/react/index.js"	2.34 KB (0%)
import { useSubscription } from "dist/react/index.js" (production)	2.29 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js"	4.37 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js" (production)	3.79 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js"	3.86 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js" (production)	3.27 KB (0%)
import { useLoadableQuery } from "dist/react/index.js"	4.12 KB (0%)
import { useLoadableQuery } from "dist/react/index.js" (production)	3.53 KB (0%)
import { useReadQuery } from "dist/react/index.js"	3.05 KB (0%)
import { useReadQuery } from "dist/react/index.js" (production)	3 KB (0%)
import { useFragment } from "dist/react/index.js"	2.15 KB (0%)
import { useFragment } from "dist/react/index.js" (production)	2.1 KB (0%)

jerelmiller · 2023-11-06T17:28:45Z

@phryneas just to clarify the intent of this change, is this strictly to shave off some bytes from the end build size, or will this have a memory impact as well since the printed query string can now be shared for multiple variables in the Trie? Would love to have a quick "why" in the changeset to describe the impact of this change so end users understand how this will positively impact them when upgrading. Thanks!

phryneas · 2023-11-06T17:32:34Z

@jerelmiller This is really just a "shaving off bytes" - the structure was a Map of Maps before and is a Map of Maps (in the form of a Trie) now. Thing is, we add slightly more bundle size as the Trie implementation now has a remove method, so we can try to counteract that by using the Trie implementation where it saves a bit of code - and here, we essentially had a hand-written Trie in our sourcecode.

=> Implementation changes, but no observable behaviour will change in any way. That will happen in other places where we will use the new remove method (e.g. SuspenseCache).

jerelmiller · 2023-11-06T23:19:00Z

@phryneas thats helpful to understand! Appreciate the context here :)

…kObservables-trie

phryneas · 2023-11-29T14:09:30Z

/release:pr

github-actions · 2023-11-29T14:13:02Z

A new release has been made for this PR. You can install it with npm i @apollo/[email protected].

phryneas · 2023-11-29T16:47:25Z

/release:pr

github-actions · 2023-11-29T16:48:38Z

A new release has been made for this PR. You can install it with npm i @apollo/[email protected].

phryneas · 2023-11-30T14:12:46Z

I've fixed up some tests, added a runtime warning if used with oudated versions of @apollo/experimental-nextjs-app-support, and had some minor code changes to ensure compatibility.

Requesting a re-review for that reason :)

You can see these changes here:

https://github.com/apollographql/apollo-client//compare/4d6e8c3c0421c2c8ed268c6cb4231948c195dd0f...0cbdfcc71e8c9edba3e9d7eca1e5548435beee07

On the other side, I've opened the PR apollographql/apollo-client-integrations#144 to accommodate for the changes in this PR. Please give it a review, too :)

phryneas · 2023-11-30T14:14:26Z

+    // TODO: remove before we release 3.9
+    Object.defineProperty(this.inFlightLinkObservables, "get", {
+      value: () => {
+        throw new Error(
+          "This version of Apollo Client requires at least @apollo/experimental-nextjs-app-support version 0.5.2."
+        );
+      },
+    });


You can see this work out over in apollographql/apollo-client-integrations#144 (comment)

jerelmiller

Thanks for catching that update to the Next.js package!

QueryManager.inFlightLinkObservables: use a strong Trie

0ee9bd1

phryneas requested review from alessbell and jerelmiller November 6, 2023 16:04

api-extractor

5d7918b

jerelmiller approved these changes Nov 6, 2023

View reviewed changes

alessbell approved these changes Nov 7, 2023

View reviewed changes

phryneas added this to the MemoryAnalysis milestone Nov 9, 2023

Merge branch 'release-3.9' into pr/inFlightLinkObservables-trie

f21530c

phryneas added the auto-cleanup 🤖 label Nov 17, 2023

phryneas and others added 4 commits November 17, 2023 17:07

Merge branch 'release-3.9' into pr/inFlightLinkObservables-trie

232e7df

Clean up Prettier, Size-limit, and Api-Extractor

4efccfa

Update .size-limit.cjs

66644ae

Merge remote-tracking branch 'origin/release-3.9' into pr/inFlightLin…

4d6e8c3

…kObservables-trie

phryneas and others added 4 commits November 29, 2023 17:34

update tests

61b2c69

change Trie value type to Observable

01c33cb

add warning for old versions of @apollo/experimental-nextjs-app-support

d506ff3

Clean up Prettier, Size-limit, and Api-Extractor

0cbdfcc

phryneas mentioned this pull request Nov 30, 2023

prepare for change in QueryManager.inFlightLinkObservable (Apollo Client 3.9 beta) apollographql/apollo-client-integrations#144

Merged

phryneas requested review from alessbell and jerelmiller November 30, 2023 14:13

phryneas commented Nov 30, 2023

View reviewed changes

jerelmiller approved these changes Nov 30, 2023

View reviewed changes

phryneas and others added 3 commits December 1, 2023 10:35

Update sixty-boxes-rest.md

21991f5

Merge branch 'release-3.9' into pr/inFlightLinkObservables-trie

0b8e4bd

Clean up Prettier, Size-limit, and Api-Extractor

7fb21fa

phryneas merged commit 1759066 into release-3.9 Dec 1, 2023

phryneas deleted the pr/inFlightLinkObservables-trie branch December 1, 2023 10:00

github-actions Bot mentioned this pull request Dec 1, 2023

Version Packages (alpha) #11353

Merged

github-actions Bot locked as resolved and limited conversation to collaborators Jan 1, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`QueryManager.inFlightLinkObservables`: use a strong `Trie`#11345

`QueryManager.inFlightLinkObservables`: use a strong `Trie`#11345
phryneas merged 14 commits intorelease-3.9from
pr/inFlightLinkObservables-trie

phryneas commented Nov 6, 2023

Uh oh!

changeset-bot Bot commented Nov 6, 2023 •

edited

Loading

Uh oh!

github-actions Bot commented Nov 6, 2023 •

edited

Loading

Uh oh!

jerelmiller commented Nov 6, 2023

Uh oh!

phryneas commented Nov 6, 2023

Uh oh!

jerelmiller commented Nov 6, 2023

Uh oh!

phryneas commented Nov 29, 2023

Uh oh!

github-actions Bot commented Nov 29, 2023

Uh oh!

phryneas commented Nov 29, 2023

Uh oh!

github-actions Bot commented Nov 29, 2023

Uh oh!

phryneas commented Nov 30, 2023 •

edited

Loading

Uh oh!

phryneas Nov 30, 2023

Uh oh!

jerelmiller left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

phryneas commented Nov 6, 2023

Should not be merged before we have a new optimism version

Before merging/releasing: add handling to @apollo/experimental-nextjs-app-support

Checklist:

Uh oh!

changeset-bot Bot commented Nov 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

github-actions Bot commented Nov 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

size-limit report 📦

Uh oh!

jerelmiller commented Nov 6, 2023

Uh oh!

phryneas commented Nov 6, 2023

Uh oh!

jerelmiller commented Nov 6, 2023

Uh oh!

phryneas commented Nov 29, 2023

Uh oh!

github-actions Bot commented Nov 29, 2023

Uh oh!

phryneas commented Nov 29, 2023

Uh oh!

github-actions Bot commented Nov 29, 2023

Uh oh!

phryneas commented Nov 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

phryneas Nov 30, 2023

Choose a reason for hiding this comment

Uh oh!

jerelmiller left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Should not be merged before we have a new `optimism` version

Before merging/releasing: add handling to `@apollo/experimental-nextjs-app-support`

changeset-bot Bot commented Nov 6, 2023 •

edited

Loading

github-actions Bot commented Nov 6, 2023 •

edited

Loading

phryneas commented Nov 30, 2023 •

edited

Loading