-
-
Notifications
You must be signed in to change notification settings - Fork 84
upgrade spring boot dependencies to 2.7.18 #68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe Changes
Sequence DiagramsThe changes in this release are related to performance improvements and version upgrades without introducing new features or significantly altering existing control flows; thus, no sequence diagrams are needed. Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #68 +/- ##
============================================
+ Coverage 68.87% 68.89% +0.01%
- Complexity 1226 1227 +1
============================================
Files 172 172
Lines 5260 5260
Branches 570 570
============================================
+ Hits 3623 3624 +1
Misses 1370 1370
+ Partials 267 266 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Outside diff range and nitpick comments (2)
CHANGES.md (2)
Line range hint
1-1: Ensure headings are surrounded by blank lines.The file should start with a blank line above the main heading for better Markdown formatting.
+ Changes by Version ==================Tools
Markdownlint
16-16: null (MD047, single-trailing-newline)
Files should end with a single newline character
Line range hint
8-8: Add blank lines around list items.For better readability and adherence to Markdown standards, ensure list items are surrounded by blank lines.
* [perf: speed up when startup meets timeout](https://github.com/apolloconfig/apollo-java/pull/64) + * [upgrade spring boot to 2.7.18](https://github.com/apolloconfig/apollo-java/pull/68) +Tools
Markdownlint
16-16: null (MD047, single-trailing-newline)
Files should end with a single newline character
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- CHANGES.md (1 hunks)
- pom.xml (1 hunks)
Files skipped from review due to trivial changes (1)
- pom.xml
Additional context used
Markdownlint
CHANGES.md
1-1: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
8-8: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
16-16: null (MD047, single-trailing-newline)
Files should end with a single newline character
Additional comments not posted (1)
CHANGES.md (1)
13-13: Document the change related to Spring Boot upgrade.The entry for upgrading Spring Boot to 2.7.18 is correctly added. Ensure that the context of why this upgrade is important is also documented to provide more value to the readers.
| * [upgrade spring boot to 2.7.18](https://github.com/apolloconfig/apollo-java/pull/68) | ||
|
|
||
| ------------------ | ||
| All issues and pull requests are [here](https://github.com/apolloconfig/apollo-java/milestone/3?closed=1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensure the file ends with a single newline character.
The file should end with a single newline character to comply with Markdown standards.
All issues and pull requests are [here](https://github.com/apolloconfig/apollo-java/milestone/3?closed=1)
+Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| All issues and pull requests are [here](https://github.com/apolloconfig/apollo-java/milestone/3?closed=1) | |
| All issues and pull requests are [here](https://github.com/apolloconfig/apollo-java/milestone/3?closed=1) | |
Tools
Markdownlint
16-16: null (MD047, single-trailing-newline)
Files should end with a single newline character
What's the purpose of this PR
upgrade spring boot dependencies to 2.7.18
Follow this checklist to help us incorporate your contribution quickly and easily:
mvn clean testto make sure this pull request doesn't break anything.CHANGESlog.Summary by CodeRabbit
New Features
apollo.cache-dir.Upgrades