Make ConfigsExportServiceTest support windows #4765
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kezhenxu94
previously approved these changes
Mar 2, 2023
nobodyiam
reviewed
Mar 3, 2023
Member
nobodyiam
left a comment
nobodyiam
left a comment
There was a problem hiding this comment.
Should we also change line 174?
FileInputStream fileInputStream = new FileInputStream("/tmp/apollo.zip");
hezhangjian
force-pushed
the
exports-test-case-support-windows
branch
from
66b85f4 to
2d983d3
Compare
Member
Author
|
@nobodyiam My fault, fixed. |
hezhangjian
force-pushed
the
exports-test-case-support-windows
branch
from
2d983d3 to
362a5b8
Compare
Codecov Report
@@ Coverage Diff @@
## master #4765 +/- ##
============================================
+ Coverage 47.27% 47.35% +0.08%
- Complexity 1655 1657 +2
============================================
Files 346 346
Lines 10662 10662
Branches 1058 1058
============================================
+ Hits 5040 5049 +9
+ Misses 5316 5307 -9
Partials 306 306
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
kezhenxu94
approved these changes
Mar 3, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this PR
Make ConfigsExportServiceTest support windows.