Skip to content

Revert "Fix #4152" #4164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nobodyiam wants to merge 1 commit into from
Closed

Revert "Fix #4152" #4164

nobodyiam wants to merge 1 commit into from

Conversation

@nobodyiam
Copy link
Member

@nobodyiam nobodyiam commented Dec 19, 2021

Reverts #4161

@nobodyiam
Revert "Fix #4152 (#4161)"
47824ba 
This reverts commit 83e87ba.
@nobodyiam
Copy link
Member Author

nobodyiam commented Dec 21, 2021

@lonre As the last change of #4161 breaks the compatibility to Spring versions prior to 4.1.1, I think we need to consider reverting the change or fixing the issue in another way.

lonre added a commit to lonre/apollo that referenced this pull request Dec 21, 2021
@lonre
Fix apolloconfig#4152
19ee6c3 
`beanFactory.isTypeMatch` may lead to the initialization of FactoryBean,
dubbo consumer is a ReferenceBean which implements FactoryBean.
support spring 3

related to apolloconfig#2328 apolloconfig#3865 apolloconfig#4161 apolloconfig#4164
@lonre lonre mentioned this pull request Dec 21, 2021
Merged
5 tasks
lonre added a commit to lonre/apollo that referenced this pull request Dec 23, 2021
@lonre
Fix apolloconfig#4152
92bc1ac 
`beanFactory.isTypeMatch` may lead to the initialization of FactoryBean,
dubbo consumer is a ReferenceBean which implements FactoryBean.
support spring 3

related to apolloconfig#2328 apolloconfig#3865 apolloconfig#4161 apolloconfig#4164
nobodyiam pushed a commit that referenced this pull request Dec 24, 2021
@lonre @nobodyiam
Fix #4152
e239350 
`beanFactory.isTypeMatch` may lead to the initialization of FactoryBean,
dubbo consumer is a ReferenceBean which implements FactoryBean.
support spring 3

related to #2328 #3865 #4161 #4164
lonre added a commit to lonre/apollo that referenced this pull request Dec 24, 2021
@lonre
Fix apolloconfig#4152
95652b1 
`beanFactory.isTypeMatch` may lead to the initialization of FactoryBean,
dubbo consumer is a ReferenceBean which implements FactoryBean.
support spring 3

related to apolloconfig#2328 apolloconfig#3865 apolloconfig#4161 apolloconfig#4164
@lonre lonre mentioned this pull request Dec 24, 2021
Merged
5 tasks
nobodyiam pushed a commit that referenced this pull request Dec 25, 2021
@lonre @nobodyiam
Fix #4152
7c6c535 
`beanFactory.isTypeMatch` may lead to the initialization of FactoryBean,
dubbo consumer is a ReferenceBean which implements FactoryBean.
support spring 3

related to #2328 #3865 #4161 #4164
@nobodyiam
Copy link
Member Author

nobodyiam commented Dec 25, 2021

As #4169 was merged, there is no need to revert the changes of #4161

@nobodyiam nobodyiam closed this Dec 25, 2021
@nobodyiam nobodyiam deleted the revert-4161-1.x branch December 25, 2021 01:49
@github-actions github-actions bot locked and limited conversation to collaborators Dec 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nobodyiam