Skip to content

fix search history. #3894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lepdou merged 2 commits into from
Aug 15, 2021
Merged

fix search history. #3894

lepdou merged 2 commits into from
Aug 15, 2021

Conversation

@Accelerator96
Copy link
Contributor

@Accelerator96 Accelerator96 commented Aug 14, 2021 •
edited
Loading

What's the purpose of this PR

修复查询修改历史的bug

Which issue(s) this PR fixes:

Fixes #3893

Brief changelog

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.
  • Update the CHANGES log.

@codecov-commenter
Copy link

codecov-commenter commented Aug 14, 2021 •
edited
Loading

Codecov Report

Merging #3894 (7bc2054) into master (9e0b1ee) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3894   +/-   ##
=========================================
  Coverage     50.10%   50.10%           
  Complexity     2479     2479           
=========================================
  Files           485      485           
  Lines         14996    14996           
  Branches       1533     1533           
=========================================
  Hits           7514     7514           
  Misses         6950     6950           
  Partials        532      532

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e0b1ee...7bc2054. Read the comment docs.

@JaredTan95 JaredTan95 added this to the 1.10.0 milestone Aug 14, 2021
@JaredTan95 JaredTan95 added area/portal apollo-portal bug Categorizes issue or PR as related to a bug. area/ui Categorizes issue or PR as related to front end and removed area/portal apollo-portal labels Aug 14, 2021
@Accelerator96
Copy link
Contributor Author

Accelerator96 commented Aug 15, 2021

1.change the same key 15 times, e.g x
2.switch to change history
3.filter the change histories with key x
4.click Load more

Screenshots:
image
image

@lepdou
Copy link
Contributor

lepdou commented Aug 15, 2021

I have verified，it's ok~

@lepdou lepdou merged commit 11c74af into apolloconfig:master Aug 15, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Aug 15, 2021
@nobodyiam nobodyiam modified the milestones: 1.10.0, 1.9.0 Aug 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

area/ui Categorizes issue or PR as related to front end bug Categorizes issue or PR as related to a bug.

Projects

None yet

Milestone

1.9.0

Development

Successfully merging this pull request may close these issues.

Load more doesn't work for commit history for specific key

5 participants

@Accelerator96 @codecov-commenter @lepdou @nobodyiam @JaredTan95