fix unit test #3669
Merged
fix unit test #3669
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3669 +/- ##
=========================================
Coverage 50.98% 50.98%
+ Complexity 2331 2330 -1
=========================================
Files 449 449
Lines 14026 14026
Branches 1426 1426
=========================================
Hits 7151 7151
+ Misses 6390 6389 -1
- Partials 485 486 +1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
newSingleThreadExecutor has a bug, and it only fixed on jdk11. while running on jdk8, it may break the unit test by accident (depend on gc)
https://bugs.openjdk.java.net/browse/JDK-8145304