Skip to content

Remove redundant invoke of trySyncFromUpstream #3698

@Technoboy-

Description

@Technoboy-
  1. As trySync has invoked trySyncFromUpstream, so remove it from setUpstreamRepository.
public LocalFileConfigRepository(String namespace, ConfigRepository upstream) {
    m_namespace = namespace;
    m_configUtil = ApolloInjector.getInstance(ConfigUtil.class);
    this.setLocalCacheDir(findLocalCacheDir(), false);
    this.setUpstreamRepository(upstream); 
    this.trySync();   
  }
public void setUpstreamRepository(ConfigRepository upstreamConfigRepository) {
    ...
    trySyncFromUpstream();
    upstreamConfigRepository.addChangeListener(this);
  }
protected void sync() {
    //sync with upstream immediately
    boolean syncFromUpstreamResultSuccess = trySyncFromUpstream();
}
  1. Use Objects.nonNull instead of !Objects.isNull

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions