Skip to content

Commit ec9534f

Browse files
author
LETSGO
authored
Update ingress-portal.yaml (#3933)
* Update ingress-portal.yaml -}} means whitespace to the right should be consumed,cause error: 'apiVersion not set'. (#apiVersion annotated) * Update ingress-adminservice.yaml syntax error * Update ingress-configservice.yaml syntax error * Update CHANGES.md
1 parent 560284d commit ec9534f

File tree

4 files changed

+7
-6
lines changed

4 files changed

+7
-6
lines changed

CHANGES.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ Apollo 1.10.0
1212
* [Make Access Key Timestamp check configurable](https://github.com/ctripcorp/apollo/pull/3908)
1313
* [remove ctrip profile](https://github.com/ctripcorp/apollo/pull/3920)
1414
* [Remove spring dependencies from internal code](https://github.com/apolloconfig/apollo/pull/3937)
15+
* [Fix issue: ingress syntax](https://github.com/apolloconfig/apollo/pull/3933)
1516

1617
------------------
1718
All issues and pull requests are [here](https://github.com/ctripcorp/apollo/milestone/8?closed=1)

scripts/helm/apollo-portal/templates/ingress-portal.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,9 @@
1616
{{- if .Values.ingress.enabled -}}
1717
{{- $fullName := include "apollo.portal.fullName" . -}}
1818
{{- $svcPort := .Values.service.port -}}
19-
{{- if semverCompare ">=1.14-0" .Capabilities.KubeVersion.GitVersion -}}
19+
{{- if semverCompare ">=1.14-0" .Capabilities.KubeVersion.GitVersion }}
2020
apiVersion: networking.k8s.io/v1beta1
21-
{{- else -}}
21+
{{- else }}
2222
apiVersion: extensions/v1beta1
2323
{{- end }}
2424
kind: Ingress

scripts/helm/apollo-service/templates/ingress-adminservice.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,9 @@
1616
{{- if .Values.adminService.ingress.enabled -}}
1717
{{- $fullName := include "apollo.adminService.fullName" . -}}
1818
{{- $svcPort := .Values.adminService.service.port -}}
19-
{{- if semverCompare ">=1.14-0" .Capabilities.KubeVersion.GitVersion -}}
19+
{{- if semverCompare ">=1.14-0" .Capabilities.KubeVersion.GitVersion }}
2020
apiVersion: networking.k8s.io/v1beta1
21-
{{- else -}}
21+
{{- else }}
2222
apiVersion: extensions/v1beta1
2323
{{- end }}
2424
kind: Ingress

scripts/helm/apollo-service/templates/ingress-configservice.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,9 @@
1616
{{- if .Values.configService.ingress.enabled -}}
1717
{{- $fullName := include "apollo.configService.fullName" . -}}
1818
{{- $svcPort := .Values.configService.service.port -}}
19-
{{- if semverCompare ">=1.14-0" .Capabilities.KubeVersion.GitVersion -}}
19+
{{- if semverCompare ">=1.14-0" .Capabilities.KubeVersion.GitVersion }}
2020
apiVersion: networking.k8s.io/v1beta1
21-
{{- else -}}
21+
{{- else }}
2222
apiVersion: extensions/v1beta1
2323
{{- end }}
2424
kind: Ingress

0 commit comments

Comments
 (0)