Skip to content

Commit 84180a2

Browse files
committed
Merge branch 'master' into feature/comment_and_blank_repeat
# Conflicts: # CHANGES.md
2 parents 1c024df + c6b165d commit 84180a2

File tree

2 files changed

+7
-4
lines changed

2 files changed

+7
-4
lines changed

CHANGES.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ Apollo 2.4.0
99
* [Feature support portal restTemplate Client connection pool config](https://github.com/apolloconfig/apollo/pull/5200)
1010
* [Feature added the ability for administrators to globally search for Value](https://github.com/apolloconfig/apollo/pull/5182)
1111
* [Fix: Resolve issues with duplicate comments and blank lines in configuration management](https://github.com/apolloconfig/apollo/pull/5232)
12+
* [Fix link namespace published items show missing some items](https://github.com/apolloconfig/apollo/pull/5240)
1213

1314
------------------
1415
All issues and pull requests are [here](https://github.com/apolloconfig/apollo/milestone/15?closed=1)

apollo-portal/src/main/resources/static/views/component/namespace-panel-master-tab.html

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -624,7 +624,7 @@ <h5>{{'Component.Namespace.Master.Items.Body.Link.NoCoverLinkItem' | translate }
624624
</thead>
625625
<tbody>
626626
<tr ng-repeat="config in namespace.publicNamespace.viewItems |orderBy:col:desc"
627-
ng-if="config.item.key && !config.isModified && !config.isDeleted">
627+
ng-if="config.item.key && ((!config.isModified && !config.isDeleted) || config.oldValue)">
628628
<td width="15%" class="cursor-pointer"
629629
title="{{'Component.Namespace.Master.Items.Body.ClickToSee' | translate }}"
630630
ng-click="showText(config.item.key)">
@@ -643,9 +643,11 @@ <h5>{{'Component.Namespace.Master.Items.Body.Link.NoCoverLinkItem' | translate }
643643
</td>
644644
<td width="30%" class="cursor-pointer"
645645
title="{{'Component.Namespace.Master.Items.Body.ClickToSee' | translate }}"
646-
ng-click="showText(config.item.value)">
647-
<span ng-bind="config.item.value | limitTo: 250"></span>
648-
<span ng-bind="config.item.value.length > 250 ? '...': ''"></span>
646+
ng-click="(config.isModified || config.isDeleted) ? showText(config.oldValue) : showText(config.item.value)">
647+
<span ng-if="config.isModified || config.isDeleted" ng-bind="config.oldValue | limitTo: 250"></span>
648+
<span ng-if="config.isModified || config.isDeleted" ng-bind="config.oldValue.length > 250 ? '...': ''"></span>
649+
<span ng-if="!config.isModified && !config.isDeleted" ng-bind="config.item.value | limitTo: 250"></span>
650+
<span ng-if="!config.isModified && !config.isDeleted" ng-bind="config.item.value.length > 250 ? '...': ''"></span>
649651
</td>
650652
<td width="13%" title="{{config.item.comment}}">
651653
<span ng-bind="config.item.comment | limitTo: 250"></span>

0 commit comments

Comments
 (0)