GUI: Write PSBTs to file with binary mode

achow101 · MarcoFalke · commit 3a126724195f · 2021-03-11T21:15:09.000+01:00
Github-Pull: #bitcoin-core/gui#188 Rebased-From: cc3971c
diff --git a/src/qt/psbtoperationsdialog.cpp b/src/qt/psbtoperationsdialog.cpp
@@ -145,7 +145,7 @@ void PSBTOperationsDialog::saveTransaction() {
     if (filename.isEmpty()) {
         return;
     }
-    std::ofstream out(filename.toLocal8Bit().data());
+    std::ofstream out(filename.toLocal8Bit().data(), std::ofstream::out | std::ofstream::binary);
     out << ssTx.str();
     out.close();
     showStatus(tr("PSBT saved to disk."), StatusLevel::INFO);
diff --git a/src/qt/sendcoinsdialog.cpp b/src/qt/sendcoinsdialog.cpp
@@ -427,7 +427,7 @@ void SendCoinsDialog::on_sendButton_clicked()
             if (filename.isEmpty()) {
                 return;
             }
-            std::ofstream out(filename.toLocal8Bit().data());
+            std::ofstream out(filename.toLocal8Bit().data(), std::ofstream::out | std::ofstream::binary);
             out << ssTx.str();
             out.close();
             Q_EMIT message(tr("PSBT saved"), "PSBT saved to disk", CClientUIInterface::MSG_INFORMATION);

Original file line number	Diff line number	Diff line change
`@@ -145,7 +145,7 @@ void PSBTOperationsDialog::saveTransaction() {`
`145`	`145`	`if (filename.isEmpty()) {`
`146`	`146`	`return;`
`147`	`147`	`}`
`148`		`- std::ofstream out(filename.toLocal8Bit().data());`
	`148`	`+ std::ofstream out(filename.toLocal8Bit().data(), std::ofstream::out \| std::ofstream::binary);`
`149`	`149`	`out << ssTx.str();`
`150`	`150`	`out.close();`
`151`	`151`	`showStatus(tr("PSBT saved to disk."), StatusLevel::INFO);`
Original file line number	Diff line number	Diff line change
`@@ -427,7 +427,7 @@ void SendCoinsDialog::on_sendButton_clicked()`
`427`	`427`	`if (filename.isEmpty()) {`
`428`	`428`	`return;`
`429`	`429`	`}`
`430`		`- std::ofstream out(filename.toLocal8Bit().data());`
	`430`	`+ std::ofstream out(filename.toLocal8Bit().data(), std::ofstream::out \| std::ofstream::binary);`
`431`	`431`	`out << ssTx.str();`
`432`	`432`	`out.close();`
`433`	`433`	`Q_EMIT message(tr("PSBT saved"), "PSBT saved to disk", CClientUIInterface::MSG_INFORMATION);`