Declare 'extend' variable in docker.js#784
Merged
apocas merged 2 commits intoapocas:masterfrom Jan 10, 2025
Merged
Conversation
This 'extend' variable is not being defined which is causing errors in node v20.
Owner
|
Not seeing any issues in Node 20.x tests, could you detail? |
Contributor
Author
|
I'm not sure of why this isn't causing issues in the tests, but new to v4.0.3 our esbuild bundle of our server with dockerode won't start because of this missing "var" declaration. I wonder if it was in a "," chain and then moved to it's own statement, but it's clearly an undefined variable. I am getting errors like: |
Owner
|
Yeah it's a typo, I missed the ";" before. Yeah this will not trigger everywhere. |
Updated fix to use ','
Contributor
Author
|
@apocas Will you accept this PR now (replace ';' with ',')? |
Owner
|
v4.0.4 published |
Contributor
Author
|
Thanks for pushing this out! It has fixed my esbuild usage of this package. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This 'extend' variable is not being defined which is causing errors in node v20.