POC: BuildKit support#766
Merged
apocas merged 2 commits intoapocas:masterfrom Jan 3, 2025
Merged
Conversation
This was referenced Jun 13, 2024
Closed
8 tasks
Contributor
Author
|
@apocas @grpc/grpc-js is updated now. Accepting the docker-modem PR would be in your hands. Anything unclear there? Besides that, the random errors remain. Do you have any idea what could be wrong here? If it is a docker bug, we could still move forward here, right? |
|
@schummar Did you happen to release this anywhere? |
Contributor
Author
No, not yet. I've been experimenting with my own library — maybe something will come of it. Let's see. |
Owner
|
Looking into this, this weekend. |
Owner
|
Just needed a quick fix: 277185b#diff-b72948b87400c946b100a05748533a06bc240e7f6ba5805fb23c3d796546b788L316 Tests are passing 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I managed to get BuildKit build to work! It is not perfect yet, but it works most of the time for me.
To do this, dockerode needs to create a gRPC server and serve over a hijacked session connection to the docker backend and attach the sessionId to the build request. Even a gRPC server without any implemented services will do, but it can also be used to return credentials to docker, which is needed when using private Images or Registries.
The are some open todos and problems:
createConnectionInjectorfeature is already in master, but not release yet (grpc-js: Add Server#createConnectionInjector API grpc/grpc-node#2675). At the moment one has to build @grpc/grpc-js locally (that's why it's linked locally in the package.json for now)Solves #601