Skip to content

refactor: enable strict type check#161

Merged
wangkailang merged 12 commits into
developfrom
refactor/strict-type-check
Jan 28, 2023
Merged

refactor: enable strict type check#161
wangkailang merged 12 commits into
developfrom
refactor/strict-type-check

Conversation

@arucil

@arucil arucil commented Jan 6, 2023

Copy link
Copy Markdown
Contributor

Submit a pull request for this project.

Why?

What?

Enable strict type checking for components and widget-sdk.

How?

@arucil arucil self-assigned this Jan 6, 2023
@arucil
arucil marked this pull request as draft January 6, 2023 16:26
@arucil
arucil marked this pull request as ready for review January 6, 2023 16:59
@arucil
arucil requested a review from a team January 6, 2023 16:59
@arucil
arucil marked this pull request as draft January 12, 2023 09:10
@arucil
arucil force-pushed the refactor/strict-type-check branch from 0039f31 to 8c80110 Compare January 12, 2023 09:20
@arucil
arucil marked this pull request as ready for review January 12, 2023 11:23
Comment thread packages/components/src/components/avatar/avatar.tsx Outdated
Comment thread packages/components/src/components/tree_view/tree_item/tree_item.tsx Outdated
@wangkailang
wangkailang merged commit 06040b8 into develop Jan 28, 2023
@wangkailang
wangkailang deleted the refactor/strict-type-check branch January 28, 2023 06:43
arucil added a commit that referenced this pull request Feb 3, 2023
Submit a pull request for this project.

<!-- If you have an Issue that related to this Pull Request, you can
copy this Issue's description -->

# Why? 
<!-- 
> Related to which issue?
> Why we need this pull request?
> What is the user story for this pull request? 
-->


# What?
<!-- 
> Can you describe this feature in detail?
> Who can benefit from it? 
-->
Enable strict type checking for `components` and `widget-sdk`.

# How?
<!-- 
> Do you have a simple description of how this pull request is
implemented?
-->

---------

Co-authored-by: wangkailang <[email protected]>
Co-authored-by: 王开朗 <[email protected]>
wumanho pushed a commit to wumanho/apitable that referenced this pull request Feb 6, 2023
Submit a pull request for this project.

<!-- If you have an Issue that related to this Pull Request, you can
copy this Issue's description -->

# Why? 
<!-- 
> Related to which issue?
> Why we need this pull request?
> What is the user story for this pull request? 
-->


# What?
<!-- 
> Can you describe this feature in detail?
> Who can benefit from it? 
-->
Enable strict type checking for `components` and `widget-sdk`.

# How?
<!-- 
> Do you have a simple description of how this pull request is
implemented?
-->

---------

Co-authored-by: wangkailang <[email protected]>
Co-authored-by: 王开朗 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants