Repository navigation
Commit 8bb6d75
authored
[Widget Preview] Isolate PageStorage scope in widget preview group expansion tile (flutter#191378)
## Description
When a preview group is collapsed and re-expanded in the Widget
Previewer, descendant scrollables (which search ancestor elements for a
`PageStorageKey` when restoring scroll offset) inherit the
`PageStorageKey` from the `ExpansionTile`. They then attempt to read the
`ExpansionTile`'s boolean expansion state as a double, throwing a
`TypeError: true: type 'bool' is not a subtype of type 'double?'`.
This PR wraps the `ExpansionTile` children in a `PageStorage` widget
with a new `PageStorageBucket`, preventing descendant scrollable widgets
from inheriting the `ExpansionTile`'s `PageStorageKey`.
## Related Issues
Fixes flutter#191242
## Tests
- Tested in widget preview scaffold template.1 parent e210443 commit 8bb6d75
2 files changed
Lines changed: 74 additions & 32 deletions
File tree
- dev/integration_tests/widget_preview_scaffold/lib/src
- packages/flutter_tools/templates/widget_preview_scaffold/lib/src
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
217 | 217 | | |
218 | 218 | | |
219 | 219 | | |
220 | | - | |
| 220 | + | |
221 | 221 | | |
222 | 222 | | |
223 | 223 | | |
| |||
235 | 235 | | |
236 | 236 | | |
237 | 237 | | |
| 238 | + | |
| 239 | + | |
| 240 | + | |
| 241 | + | |
| 242 | + | |
| 243 | + | |
| 244 | + | |
| 245 | + | |
238 | 246 | | |
239 | 247 | | |
240 | 248 | | |
241 | 249 | | |
242 | 250 | | |
243 | 251 | | |
244 | 252 | | |
245 | | - | |
| 253 | + | |
246 | 254 | | |
247 | 255 | | |
248 | 256 | | |
| |||
253 | 261 | | |
254 | 262 | | |
255 | 263 | | |
256 | | - | |
| 264 | + | |
257 | 265 | | |
258 | 266 | | |
259 | 267 | | |
| |||
269 | 277 | | |
270 | 278 | | |
271 | 279 | | |
272 | | - | |
| 280 | + | |
| 281 | + | |
| 282 | + | |
273 | 283 | | |
274 | 284 | | |
275 | 285 | | |
276 | 286 | | |
277 | 287 | | |
278 | 288 | | |
279 | 289 | | |
280 | | - | |
281 | | - | |
| 290 | + | |
| 291 | + | |
282 | 292 | | |
283 | 293 | | |
284 | | - | |
285 | | - | |
286 | | - | |
287 | | - | |
288 | | - | |
289 | | - | |
290 | | - | |
291 | | - | |
292 | | - | |
293 | | - | |
| 294 | + | |
| 295 | + | |
| 296 | + | |
| 297 | + | |
| 298 | + | |
| 299 | + | |
| 300 | + | |
| 301 | + | |
| 302 | + | |
| 303 | + | |
| 304 | + | |
| 305 | + | |
| 306 | + | |
| 307 | + | |
| 308 | + | |
| 309 | + | |
| 310 | + | |
| 311 | + | |
| 312 | + | |
| 313 | + | |
| 314 | + | |
294 | 315 | | |
295 | 316 | | |
296 | 317 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
217 | 217 | | |
218 | 218 | | |
219 | 219 | | |
220 | | - | |
| 220 | + | |
221 | 221 | | |
222 | 222 | | |
223 | 223 | | |
| |||
235 | 235 | | |
236 | 236 | | |
237 | 237 | | |
| 238 | + | |
| 239 | + | |
| 240 | + | |
| 241 | + | |
| 242 | + | |
| 243 | + | |
| 244 | + | |
| 245 | + | |
238 | 246 | | |
239 | 247 | | |
240 | 248 | | |
241 | 249 | | |
242 | 250 | | |
243 | 251 | | |
244 | 252 | | |
245 | | - | |
| 253 | + | |
246 | 254 | | |
247 | 255 | | |
248 | 256 | | |
| |||
253 | 261 | | |
254 | 262 | | |
255 | 263 | | |
256 | | - | |
| 264 | + | |
257 | 265 | | |
258 | 266 | | |
259 | 267 | | |
| |||
269 | 277 | | |
270 | 278 | | |
271 | 279 | | |
272 | | - | |
| 280 | + | |
| 281 | + | |
| 282 | + | |
273 | 283 | | |
274 | 284 | | |
275 | 285 | | |
276 | 286 | | |
277 | 287 | | |
278 | 288 | | |
279 | 289 | | |
280 | | - | |
281 | | - | |
| 290 | + | |
| 291 | + | |
282 | 292 | | |
283 | 293 | | |
284 | | - | |
285 | | - | |
286 | | - | |
287 | | - | |
288 | | - | |
289 | | - | |
290 | | - | |
291 | | - | |
292 | | - | |
293 | | - | |
| 294 | + | |
| 295 | + | |
| 296 | + | |
| 297 | + | |
| 298 | + | |
| 299 | + | |
| 300 | + | |
| 301 | + | |
| 302 | + | |
| 303 | + | |
| 304 | + | |
| 305 | + | |
| 306 | + | |
| 307 | + | |
| 308 | + | |
| 309 | + | |
| 310 | + | |
| 311 | + | |
| 312 | + | |
| 313 | + | |
| 314 | + | |
294 | 315 | | |
295 | 316 | | |
296 | 317 | | |
| |||
0 commit comments