Repository navigation
Commit 07510ad
authored
Move iOS compile benchmarks to Mac_benchmark and pin Mac_benchmark to M1 (flutter#192472)
Part of flutter#186414
This batch moves the 4 iOS compile benchmarks off physical-device bots
and onto the pinned benchmark pool:
* `basic_material_app_ios__compile`
* `flutter_gallery_ios__compile`
* `hello_world_ios__compile`
* `imitation_game_flutter` (task: `imitation_game_flutter__compile`)
These tasks only run `flutter build ios` and never launch an app on the
attached iPhone (details in [flutter#186414
(comment)](flutter#186414 (comment))).
On `Mac_arm64_ios` they tie up physical devices and, because that pool
mixes M1 and M4 Pro hosts, every metric is split into two disconnected
Skia Perf series (`device_type=iPhone_11` vs `iPhone_16_Pro`) with a
~40–60% timing gap.
Per [flutter#186414
(comment)](flutter#186414 (comment)),
instead of moving them to the unpinned `Mac_arm64` pool:
**Changes**
- `platform_properties.mac_benchmark`: `mac_model` `"Macmini8,1"`
(Intel, being turned down per
[flutter.dev/go/macos-intel-deprecation](https://flutter.dev/go/macos-intel-deprecation))
→ `"Macmini9,1"` (Apple Silicon M1 Mac mini), plus `cpu: arm64` and an
`arm64` tag.
- Moved the 4 targets from `Mac_arm64_ios` to `Mac_benchmark` with
`bringup: true`. They inherit `device_type: none` and `["devicelab",
"hostonly", "mac", "arm64"]` from the platform; dropping the `ios` tag
also stops the devicelab recipe from running `ideviceinfo` (which would
fail on a host-only bot). `flutter_gallery_ios__compile` keeps the
`ruby` dependency for CocoaPods, matching
`flutter_gallery_macos__compile`.
- `imitation_game_swiftui` stays on `Mac_arm64_ios` — it runs
`xcodebuild test` against a physical device.
**Heads-up for the metrics sheriff**
- All 13 existing `Mac_benchmark` macOS targets (`*_macos__compile`,
`*_macos__start_up`, `complex_layout_scroll_perf_macos*`,
`new_gallery_macos_impeller__transition_perf`,
`flutter_tool_startup__macos`, …) move from Intel to M1 hardware with
this change, so their baselines will shift (and the `arch` benchmark tag
changes from `intel` to `arm`). Expect one-time step changes on Skia
Perf rather than regressions.
- Host-only `Macmini9,1` capacity in `luci.flutter.prod` is ~56 bots (vs
~37 Intel `Macmini8,1`), shared with `Mac_arm64`; today that pool is all
M1, so the pin mostly future-proofs against M4 Pros being added.1 parent ed2392e commit 07510ad
1 file changed
Lines changed: 19 additions & 14 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
211 | 211 | | |
212 | 212 | | |
213 | 213 | | |
214 | | - | |
| 214 | + | |
| 215 | + | |
| 216 | + | |
| 217 | + | |
| 218 | + | |
| 219 | + | |
215 | 220 | | |
216 | 221 | | |
217 | | - | |
| 222 | + | |
218 | 223 | | |
219 | 224 | | |
220 | 225 | | |
| |||
5362 | 5367 | | |
5363 | 5368 | | |
5364 | 5369 | | |
5365 | | - | |
| 5370 | + | |
5366 | 5371 | | |
5367 | 5372 | | |
| 5373 | + | |
5368 | 5374 | | |
5369 | 5375 | | |
5370 | | - | |
5371 | | - | |
5372 | 5376 | | |
5373 | 5377 | | |
5374 | 5378 | | |
| |||
5472 | 5476 | | |
5473 | 5477 | | |
5474 | 5478 | | |
5475 | | - | |
| 5479 | + | |
5476 | 5480 | | |
5477 | 5481 | | |
| 5482 | + | |
5478 | 5483 | | |
5479 | 5484 | | |
5480 | | - | |
5481 | | - | |
| 5485 | + | |
| 5486 | + | |
| 5487 | + | |
| 5488 | + | |
5482 | 5489 | | |
5483 | 5490 | | |
5484 | 5491 | | |
| |||
5499 | 5506 | | |
5500 | 5507 | | |
5501 | 5508 | | |
5502 | | - | |
| 5509 | + | |
5503 | 5510 | | |
5504 | 5511 | | |
| 5512 | + | |
5505 | 5513 | | |
5506 | 5514 | | |
5507 | | - | |
5508 | | - | |
5509 | 5515 | | |
5510 | 5516 | | |
5511 | | - | |
| 5517 | + | |
5512 | 5518 | | |
5513 | 5519 | | |
| 5520 | + | |
5514 | 5521 | | |
5515 | 5522 | | |
5516 | | - | |
5517 | | - | |
5518 | 5523 | | |
5519 | 5524 | | |
5520 | 5525 | | |
| |||
0 commit comments