Repository navigation
fix(utils): keep whitespace of elements nested in <pre> in htmlToText - #4348
Merged
Merged
Conversation
Whitespace was only preserved for text nodes whose direct parent is <pre>, so <pre><code>...</code></pre>, the usual markup for code blocks, was collapsed into a single line.
github-actions
Bot
added
the
t-tooling
barjin
approved these changes
Nov 5, 2026
barjin
left a comment
barjin
left a comment
Member
There was a problem hiding this comment.
Thank you for your contribution @b84330808, lgtm.
I pushed one small commit on top, so code blocks keep their full indentation.
barjin
enabled auto-merge (squash)
November 5, 2026 16:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
htmlToTextonly kept whitespace for text nodes whose direct parent is<pre>. Code blocks are usually<pre><code>…</code></pre>, so their indentation and line breaks were collapsed into one line. The "inside<pre>" state is now passed down while walking the tree.