Skip to content

Remove unnecessary configuration variables#7

Merged
greyli merged 12 commits intomasterfrom
update-config
Apr 11, 2021
Merged

Remove unnecessary configuration variables#7
greyli merged 12 commits intomasterfrom
update-config

Conversation

@greyli
Copy link
Copy Markdown
Member

@greyli greyli commented Apr 2, 2021

Merge the following configuration variables:

  • DEFAULT_2XX_DESCRIPTION
  • DEFAULT_200_DESCRIPTION
  • DEFAULT_201_DESCRIPTION
  • DEFAULT_204_DESCRIPTION

to SUCCESS_DESCRIPTION.

Remove:

  • AUTO_HTTP_ERROR_RESPONSE
  • AUTH_ERROR_SCHEMA

Checklist

  • Update configs
  • Update changelog
  • Add configuration docs

greyli added 8 commits April 2, 2021 18:18
Replace following:
- DEFAULT_2XX_DESCRIPTION
- DEFAULT_200_DESCRIPTION
- DEFAULT_201_DESCRIPTION
- DEFAULT_204_DESCRIPTION
with:
- SUCCESS_DESCRIPTION
Use HTTP_ERROR_SCHEMA for auth error
The SWAGGER_UI_OAUTH2_REDIRECT_URL config is removed.
@codecov-io
Copy link
Copy Markdown

codecov-io commented Apr 8, 2021

Codecov Report

Merging #7 (3601c7a) into master (3b71347) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 3601c7a differs from pull request most recent head 69ec56b. Consider uploading reports for the commit 69ec56b to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##            master        #7   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           12        12           
  Lines          663       608   -55     
  Branches       119       117    -2     
=========================================
- Hits           663       608   -55     
Impacted Files Coverage Δ
apiflask/app.py 100.00% <100.00%> (ø)
apiflask/settings.py 100.00% <100.00%> (ø)
apiflask/types.py 100.00% <0.00%> (ø)
apiflask/fields.py 100.00% <0.00%> (ø)
apiflask/schemas.py 100.00% <0.00%> (ø)
apiflask/security.py 100.00% <0.00%> (ø)
apiflask/blueprint.py 100.00% <0.00%> (ø)
apiflask/decorators.py 100.00% <0.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b71347...69ec56b. Read the comment docs.

@greyli greyli merged commit b243797 into master Apr 11, 2021
@greyli greyli deleted the update-config branch April 11, 2021 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants