Tom Yang codekitchen Sprint7 task1#673
Merged
greyli merged 3 commits intoapiflask:mainfrom Sep 21, 2025
Merged
Conversation
Member
|
Merged, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the Python version 3.8 all unit test works fine, but up Python 3.9 there is an extra 'additionalProperties': False within the rv.json['components']['schemas']['MyName'] and rv.json['components']['schemas']['CustomHTTPError'], so I use the if sys.version_info >= (3, 9) to assert with additionalProperties and else to assert w/o additionalProperties, which this will eliminate the inconsisten behavior between different Python Version
fixes #
Checklist:
docsfolder and in code docstring.CHANGES.mdsummarizing the change and linking to the issue.*Version changed*or*Version added*note in any relevant docs and docstring.pytestandtox, no tests failed.