Skip to content

[Feature] support decorators to the openapi#508

Merged
greyli merged 14 commits intoapiflask:mainfrom
FarmerChillax:feature-support-decorators-to-openapi
Dec 14, 2023
Merged

[Feature] support decorators to the openapi#508
greyli merged 14 commits intoapiflask:mainfrom
FarmerChillax:feature-support-decorators-to-openapi

Conversation

@FarmerChillax
Copy link
Copy Markdown
Member

@FarmerChillax FarmerChillax commented Nov 19, 2023

fixes #483

Checklist:

  • Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
  • Add or update relevant docs, in the docs folder and in code docstring.
  • Add an entry in CHANGES.md summarizing the change and linking to the issue.
  • Add *Version changed* or *Version added* note in any relevant docs and docstring.
  • Run pytest and tox, no tests failed.

Copy link
Copy Markdown
Contributor

@wlach wlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(just a drive-by suggestion, not the maintainer) This looks great! I wanted this feature and had to resort to various hacks involving using APIFlask internals to get it to work. This is 100x better.

@tsokalski
Copy link
Copy Markdown
Contributor

This looks good to me too!

@greyli greyli added the codekitchen-soos CodeKitchen Community Song of Open-Source label Nov 25, 2023
@FarmerChillax FarmerChillax requested a review from greyli November 25, 2023 15:37
- Move the configuration docs to the correct place and add more docs
- Add the default values to setting.py
- Update README for examples
- Improve the naming of function/variables
@greyli greyli merged commit 870ee6b into apiflask:main Dec 14, 2023
@greyli
Copy link
Copy Markdown
Member

greyli commented Dec 14, 2023

Merged, thanks!

P.S. I made some improvements in 08b48bc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

codekitchen-soos CodeKitchen Community Song of Open-Source

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for adding decorators to the OpenAPI spec and documentation UI endpoints

4 participants