Skip to content

Add default parameter for get_reason_phrase#45

Merged
greyli merged 2 commits intomasterfrom
improve-get-reason-phrase
May 11, 2021
Merged

Add default parameter for get_reason_phrase#45
greyli merged 2 commits intomasterfrom
improve-get-reason-phrase

Conversation

@greyli
Copy link
Copy Markdown
Member

@greyli greyli commented May 11, 2021

Add a default parameter for get_reason_phrase helper, defaults to Unknown.

Checklist:

  • Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
  • Add or update relevant docs, in the docs folder and in code docstring.
  • Add an entry in CHANGES.md summarizing the change and linking to the issue and your username.
  • Add *Version Changed* or *Version Added* note in any relevant docs and docstring.
  • Run pytest and tox, no tests failed.

@netlify
Copy link
Copy Markdown

netlify bot commented May 11, 2021

@greyli greyli merged commit b9d05b1 into master May 11, 2021
@greyli greyli deleted the improve-get-reason-phrase branch May 11, 2021 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant