Import and rename decorators from Marshmallow#43
Merged
Conversation
|
Deploy preview for apiflask ready! Built with commit f0428b7 |
Codecov Report
@@ Coverage Diff @@
## master #43 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 14 14
Lines 798 805 +7
Branches 147 147
=========================================
+ Hits 798 805 +7
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename the following decorators from Marshmallow:
Not sure if it's a good idea, but this is definitely what I want to do. The four hooks are changed to match the naming style in Flask (i.e.,
before_request,after_request, etc.). Thevalidates->validatechange meant to make the names more simple.This change will introduce an API difference between APIFlask and Marshmallow, I will address these changes at the beginning of the schema docs (working in progress).