This repository was archived by the owner on Nov 8, 2024. It is now read-only.
Conversation
klokane
approved these changes
May 7, 2019
kylef
suggested changes
May 7, 2019
Member
kylef
left a comment
kylef
left a comment
There was a problem hiding this comment.
Can you add a changelog entry and a release commit too? That way we can merge this and release in one go saves separate PR and review cycle.
https://github.com/apiaryio/drafter/pull/681/files contains the exact files that need to be changed for release.
test/fixtures/mson/issue-689.apib
Outdated
|
|
||
| ## ContactInfo (object) | ||
|
|
||
| + email: [email protected] (string) |
Member
There was a problem hiding this comment.
Please use example.com, it's a reserved domain name, [email protected] could be a legit persons email address which we probably don't want to use in our tests.
Suggested change
| + email: june@email.com (string) | |
| + email: user@example.com (string) |
kylef
approved these changes
May 7, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #689