feat: endpoint choose by health check#109
Conversation
tzssangglass
changed the title
|
@ Yiyiyimu welcome to look at this PR |
membphis
left a comment
membphis
left a comment
There was a problem hiding this comment.
LGTM, @spacewander would you have time to look at this PR?
|
@Yiyiyimu welcome to look at this PR too |
Yiyiyimu
left a comment
Yiyiyimu
left a comment
There was a problem hiding this comment.
Most code logic LGTM, but some grammar needs to be refined
|
|
||
|
|
||
|
|
||
| === TEST 8: has no healthy etcd endpoint, follow old style |
There was a problem hiding this comment.
I didn't get why when no endpoints are healthy, we should follow old style. Since as #101 talked about
When all instances of a certain api fail (such as auth api), it will cause crazy retries, which may eventually overwhelm the ETCD cluster.
Following old styles still could not solve this problem
There was a problem hiding this comment.
I can't refute this example.
we do not request etcd when all etcd instances are down.
what do you think @membphis ?
There was a problem hiding this comment.
IMO maybe we could leave some warnings and like add some delay for continuous retries? I'm not so sure.
Hi @nic-chen do you have some opinions on this
|
ping @tzssangglass |
later, my computer is broken, will continue after repairing. |
…ty-etcd into healthcheck Conflicts: health_check.md
4 participants
fix #101
fix #55