Skip to content

Conversation

@KDederichs
Copy link
Contributor

Q A
Branch? 3.0
Tickets n/a
License MIT
Doc PR n/a

Since the current tests didn't catch the issue fixed with #5324 I thought I'd be good to add some tests that run against the lowest possible dependencies.

@KDederichs
Copy link
Contributor Author

KDederichs commented Jan 12, 2023

Removed willdurand/negotiation:2.x since it's incompatible with PHP 8, doctrine:3.0 has issues with union types and symfony/service-contracts:<3 breaks with some annotations, phpunit:<9.5 removed some deprecated methods, phpspec/prophecy:<1.15 can't handle static

@soyuka
Copy link
Member

soyuka commented Jan 12, 2023

nice, we had that not sure how it got removed, you can use ci: test against lowest dependencies as commit message.

@KDederichs KDederichs changed the title chore(ci): add test against lowest dependencies ci: test against lowest dependencies Jan 12, 2023
@KDederichs
Copy link
Contributor Author

@soyuka changed it

@soyuka soyuka merged commit e88a7f6 into api-platform:3.0 Jan 12, 2023
@soyuka
Copy link
Member

soyuka commented Jan 12, 2023

I merged like this and we try to fix lowest in your other PR?

Thanks!

KDederichs added a commit to KDederichs/core that referenced this pull request Jan 12, 2023
soyuka pushed a commit that referenced this pull request Jan 12, 2023
* chore(deprecation): Only use ValueResolverInterface if it exists

* chore(deprecation): fix CS

* chore(deprecation): Add new CompatibleValueResolverInterface

* fix(graphql): use depth for nested resource class operation (#5314)

* test: add reproducer for bug 5310

* fix(graphql): use depth for nested resource class operation

Co-authored-by: Alan Poulain <[email protected]>

* ci: test against lowest dependencies (#5329)

Co-authored-by: Nico Haase <[email protected]>
Co-authored-by: Alan Poulain <[email protected]>
soyuka added a commit to soyuka/core that referenced this pull request Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants