Repository navigation
fix(dumbbell): don't draw end dots for a null row - #5357
Merged
junedchhipa merged 1 commit intoOct 23, 2026
Merged
Conversation
In the `y: [lo, hi]` form of a dumbbell (`plotOptions.bar.isDumbbell`), a row with `y: null` still got two end dots. Their values were null, so the dots had no position and were drawn on the plot's top edge (left edge when horizontal). getDumbbellEnds now skips null ends, as the `chart.type: 'dumbbell'` series form already does. Fixes #4458 Co-Authored-By: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New Pull Request
In a dumbbell drawn from
y: [lo, hi]data (plotOptions.bar.isDumbbell), a row withy: nullstill got its two end dots. Their values were null, so the dots had no position and were drawn on the top edge of the plot (the left edge whenhorizontal: true). That is the stray pair of dots at the top in the issue's screenshot.getDumbbellEndsnow skips null ends in they: [lo, hi]form, as thechart.type: 'dumbbell'series form already does. A row with no values draws no dots. A row with one null end keeps the dot for its other end. A value of0still gets its dot.This does not change the issue's second example, where series with different x values are lined up by position.
Fixes #4458
Type of change
Checklist:
Tests: three new cases in
tests/unit/dumbbell.spec.js: a unit check ofgetDumbbellEnds, and the issue's chart rendered as columns and as bars. They fail on main and pass with the fix. The fullvitest run tests/unit/suite passes, andcheck:sizeis within budget.I used Claude Code to write this change.