ZEPPELIN-953 ] Jquery.floatThead delete the information from the license file.#960
Closed
cloverhearts wants to merge 2 commits intoapache:masterfrom
cloverhearts:ZEPPELIN-953
Closed
ZEPPELIN-953 ] Jquery.floatThead delete the information from the license file.#960cloverhearts wants to merge 2 commits intoapache:masterfrom cloverhearts:ZEPPELIN-953
cloverhearts wants to merge 2 commits intoapache:masterfrom
cloverhearts:ZEPPELIN-953
Conversation
Contributor
|
Agreed, LGTM 👍 |
Contributor
|
This CI failure was fixed with #958. Can you rebase with master and re-trigger ? |
Member
Author
|
@prabhjyotsingh Okay, Rebasing is executed. |
Member
|
LGTM |
Member
|
Looks great to me, @cloverhearts thank you for catching it. CI is green, merging if there is no more discussion |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
<Jquery.floatThead> is no longer used.
But the license document contains the appropriate information.
Due to the following PR <jquery.floatThead> was removed.
Resulting in a using < HandsonTable >.
#858
What type of PR is it?
Documentation
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-953
Questions: