Revise documentation about basic authentication#877
Closed
yoonjs2 wants to merge 19 commits intoapache:masterfrom
yoonjs2:nginx-auth-revised
Closed
Revise documentation about basic authentication#877yoonjs2 wants to merge 19 commits intoapache:masterfrom yoonjs2:nginx-auth-revised
yoonjs2 wants to merge 19 commits intoapache:masterfrom
yoonjs2:nginx-auth-revised
Conversation
…. Remove unnecessary spaces.
…. Remove unnecessary spaces.
# Conflicts: # docs/interpreter/cassandra.md
# Conflicts: # docs/interpreter/cassandra.md
# Conflicts: # docs/interpreter/cassandra.md
# Conflicts: # docs/interpreter/cassandra.md # docs/interpreter/spark.md # docs/manual/interpreters.md
# Conflicts: # docs/security/authentication.md
| Then check HTTP Basic Authentication works in browser. If you can see regular basic auth popup and then able to login with credential you entered into `.htpasswd` you are good to go. | ||
|
|
||
| <img src="/assets/themes/zeppelin/img/screenshots/authentication-basic-auth-nginx-request.png" /> | ||
| <img src="/assets/themes/zeppelin/img/screenshots/authentication-basic-auth-nginx-https.png" /> |
Member
There was a problem hiding this comment.
Would you also remove image files
"docs/assets/themes/zeppelin/img/screenshots/authentication-basic-auth-nginx-request.png" and "docs/assets/themes/zeppelin/img/screenshots/authentication-basic-auth-nginx-https.png" ?
Contributor
Author
There was a problem hiding this comment.
@Leemoonsoo No problem. I'd remove png files you pointed out :)
Thank you for your review.
Member
|
Thanks @yoonjs2 for the nice improvement on documentation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Revised documentation about nginx authentication after receive few comments about it. Especially for users who using old version of nginx (older than 1.3) facing websocket failures when using zeppelin after follow instructions. I put more information for those users to encourage use of latest version of nginx if possible + fix few grammars for readability.
What type of PR is it?
Documentation