Conversation
|
Attempt to deal with github showing commits as part of this branch despite the fact that they were already in master. Remake of this pull request: |
|
...There are no changes that would make it work on one spark version and not on another. Closing and reopening to trigger rebuild. |
|
@Leemoonsoo @felixcheung Ping. |
| Properties prop = interpreterGroup.getProperty(); | ||
| //Happens during tests. | ||
| if (prop == null) | ||
| prop = new Properties(); |
There was a problem hiding this comment.
I know we don't have style check for this official but could we put single line into bracket too? It would help readability and prevent possible merge mistakes.
(same for L143)
http://embeddedgurus.com/barr-code/2014/03/apples-gotofail-ssl-security-bug-was-easily-preventable/
3 participants
What is this PR for?
This is a step towards creating a REST endpoint from resource pools https://issues.apache.org/jira/browse/ZEPPELIN-699
It allows resources to be saved to disk so that they can be reloaded.
What type of PR is it?
Improvement
Todos
What is the Jira issue?
Partially implements this: https://issues.apache.org/jira/browse/ZEPPELIN-699
Note, that this pull request is dependent upon this one:
#782
How should this be tested?
You should see new resource files created in notebook/zeppelin_resources
Screenshots (if appropriate)
Questions: