Skip to content

[MINOR] Set log4j.configuration into JAVA_OPTS and JAVA_INTP_OPTS explicitly#830

Closed
jongyoul wants to merge 1 commit intoapache:masterfrom
jongyoul:minor-set-log4j-explicitly
Closed

[MINOR] Set log4j.configuration into JAVA_OPTS and JAVA_INTP_OPTS explicitly#830
jongyoul wants to merge 1 commit intoapache:masterfrom
jongyoul:minor-set-log4j-explicitly

Conversation

@jongyoul
Copy link
Copy Markdown
Member

What is this PR for?

Set log4j into JVM option for enforcing logging configuration.

What type of PR is it?

[Bug Fix]

Todos

  • - Set "-Dlog4j.configuration=..." into JVM option

What is the Jira issue?

Minor issue

How should this be tested?

  1. Run spark with default log4j setting and check logs/zeppelin*.out. you can see logs from Spark.
  2. Apply this patch.
  3. Run spark with default log4j setting and check logs/zeppelin-interpreter*.log. you can see logs from Spark.

Screenshots (if appropriate)

Questions:

  • Does the licenses files need update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? No

- Added "-Dlog4j.configuration" into JAVA_OPTS and JAVA_INTP_OPTS explicitly
@Leemoonsoo
Copy link
Copy Markdown
Member

LGTM

@jongyoul
Copy link
Copy Markdown
Member Author

Merging if there's no more discussion.

@asfgit asfgit closed this in 53451e9 Apr 13, 2016
onkarshedge pushed a commit to onkarshedge/incubator-zeppelin that referenced this pull request May 11, 2016
…licitly

### What is this PR for?
Set log4j into JVM option for enforcing logging configuration.

### What type of PR is it?
[Bug Fix]

### Todos
* [x] - Set "-Dlog4j.configuration=..." into JVM option

### What is the Jira issue?
Minor issue

### How should this be tested?

1. Run spark with default log4j setting and check logs/zeppelin*.out. you can see logs from Spark.
1. Apply this patch.
1. Run spark with default log4j setting and check logs/zeppelin-interpreter*.log. you can see logs from Spark.

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No

Author: Jongyoul Lee <[email protected]>

Closes apache#830 from jongyoul/minor-set-log4j-explicitly and squashes the following commits:

2185284 [Jongyoul Lee] [MINOR] - Added "-Dlog4j.configuration" into JAVA_OPTS and JAVA_INTP_OPTS explicitly
@aarcro
Copy link
Copy Markdown

aarcro commented Sep 9, 2016

I had to remove this to get my %sql interpreter running again (on EMR). From what I can tell on the yarn resource manager, something owned by the hadoop user was trying to write to zeppelin's log file. I assume zeppelin's log4j config, shouldn't get used by the spark proc behind it, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants