Skip to content

[MINOR] Remove stdout and stderr#829

Closed
jongyoul wants to merge 2 commits intoapache:masterfrom
jongyoul:minor-remove-stdout-stderr
Closed

[MINOR] Remove stdout and stderr#829
jongyoul wants to merge 2 commits intoapache:masterfrom
jongyoul:minor-remove-stdout-stderr

Conversation

@jongyoul
Copy link
Copy Markdown
Member

@jongyoul jongyoul commented Apr 12, 2016

What is this PR for?

Change system.out and system.err into logger.info

What type of PR is it?

[Improvement]

Todos

  • - Fixed to remove system.out and system.err

What is the Jira issue?

This is very trivial and minor issue

How should this be tested?

Check your logs/zeppelin_.out to see "------ Create new SparkContext ..."
Apply this patch
Check your logs/zeppelin_.log to see "------ Create new SparkContext ..."

Screenshots (if appropriate)

Questions:

  • Does the licenses files need update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? No

jongyoul added 2 commits April 12, 2016 10:01
@jongyoul
[MINOR]
180e2c1 
- Change System.out and System.err into logger.info
@jongyoul
[Minor]
f703fe3 
- Revert test code
@jongyoul
Copy link
Copy Markdown
Member Author

jongyoul commented Apr 12, 2016

The failure is irrelative.

[ERROR] npm ERR! shasum check failed for /tmp/npm-9826-4ecc065c/registry.npmjs.org/multiparty/-/multiparty-2.2.0.tgz
[ERROR] npm ERR! Expected: a567c2af000ad22dc8f2a653d91978ae1f5316f4
[ERROR] npm ERR! Actual:   774ba609dc52b6137bb5faa41ce9b72d851ffb38
[ERROR] npm ERR! From:     https://registry.npmjs.org/multiparty/-/multiparty-2.2.0.tgz

[ERROR] npm ERR! shasum check failed for /tmp/npm-9821-09fbabd5/registry.npmjs.org/socket.io-client/-/socket.io-client-0.9.16.tgz
[ERROR] npm ERR! Expected: 4da7515c5e773041d1b423970415bcc430f35fc6
[ERROR] npm ERR! Actual:   417d664394ed5a959deea7a56bc9993d94289ecb
[ERROR] npm ERR! From:     https://registry.npmjs.org/socket.io-client/-/socket.io-client-0.9.16.tgz

@jongyoul jongyoul closed this Apr 12, 2016
@jongyoul jongyoul reopened this Apr 12, 2016
@Leemoonsoo
Copy link
Copy Markdown
Member

Leemoonsoo commented Apr 12, 2016

LGTM

@jongyoul
Copy link
Copy Markdown
Member Author

jongyoul commented Apr 12, 2016

Merging if there's no more discussion.

@asfgit asfgit closed this in 1fc67f0 Apr 13, 2016
onkarshedge pushed a commit to onkarshedge/incubator-zeppelin that referenced this pull request May 11, 2016
@jongyoul @onkarshedge
[MINOR] Remove stdout and stderr
c7618ef 
### What is this PR for?
Change system.out and system.err into logger.info

### What type of PR is it?
[Improvement]

### Todos
* [x] - Fixed to remove system.out and system.err

### What is the Jira issue?
This is very trivial and minor issue

### How should this be tested?
Check your logs/zeppelin*.out to see "------ Create new SparkContext ..."
Apply this patch
Check your logs/zeppelin*.log to see "------ Create new SparkContext ..."

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No

Author: Jongyoul Lee <[email protected]>

Closes apache#829 from jongyoul/minor-remove-stdout-stderr and squashes the following commits:

f703fe3 [Jongyoul Lee] [Minor] - Revert test code
180e2c1 [Jongyoul Lee] [MINOR] - Change System.out and System.err into logger.info
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jongyoul @Leemoonsoo