Generate unique temporary files for Python and R Spark Interpreters.#823
Closed
mudsam wants to merge 1 commit intoapache:masterfrom
Closed
Generate unique temporary files for Python and R Spark Interpreters.#823mudsam wants to merge 1 commit intoapache:masterfrom
mudsam wants to merge 1 commit intoapache:masterfrom
Conversation
Add cleanup of Python temporary file on close().
Contributor
|
The patch shouldn't be necessary for the R interpreter from PR 208 right? |
Author
|
As far as I can tell it would not be needed for the R interpreter from PR 208. |
Member
|
Thanks for the fix. LGTM and CI failure is irrelevant to this change. |
Member
|
LGTM |
Member
|
Merging it into master |
onkarshedge
pushed a commit
to onkarshedge/incubator-zeppelin
that referenced
this pull request
May 11, 2016
### What is this PR for? Generate unique temporary files for Python and R Spark interpreters using java.io.File.createTempFile. Remove the temporary file for the Python interpreter when the interpreter is closed (is already being done in the R interpreter). Without this fix it is not possible to run more than one Zeppelin interpreter on the same server due to file owner conflicts between instances. ### What type of PR is it? Bug Fix ### Todos ### What is the Jira issue? No Jira opened for this ### How should this be tested? ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: Johan Muedsam <[email protected]> Closes apache#823 from mudsam/master and squashes the following commits: 0c018b4 [Johan Muedsam] Generate unique temporary files for Python and R Spark Interpreters. Add cleanup of Python temporary file on close().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Generate unique temporary files for Python and R Spark interpreters using java.io.File.createTempFile.
Remove the temporary file for the Python interpreter when the interpreter is closed (is already being done in the R interpreter).
Without this fix it is not possible to run more than one Zeppelin interpreter on the same server due to file owner conflicts between instances.
What type of PR is it?
Bug Fix
Todos
What is the Jira issue?
No Jira opened for this
How should this be tested?
Screenshots (if appropriate)
Questions: