Closed
Conversation
### What is this PR for? Somehow final squashed merge commit for apache#815 - fb8e77b does not include 2 changes out of 3 changes: - eeb411e - 9baf57b This PR re-applies Leemoonsoo work on master and should fix the CI ### What type of PR is it? Hot Fix ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Alexander Bezzubov <[email protected]> Closes apache#820 from bzz/re-apply-SparkR-implementation-conflict-815 and squashes the following commits: 60267b4 [Alexander Bezzubov] Change interpreter listing order, re-apply eeb411e 7ec1e2c [Alexander Bezzubov] Change node and npm version, re-apply 9baf57b
### What is this PR for? 2 minor non-code style improvements. HT anthonycorbacho ### What type of PR is it? Improvement ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Alexander Bezzubov <[email protected]> Closes apache#821 from bzz/fix-minor-style-issues and squashes the following commits: 04e214c [Alexander Bezzubov] Fix minor non-code style issues
### What is this PR for? Fix Spark download on CI ### What type of PR is it? Hot Fix ### What is the Jira issue? [ZEPPELIN-783](https://issues.apache.org/jira/browse/ZEPPELIN-783) ### How should this be tested? CI must be green ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Alexander Bezzubov <[email protected]> Closes apache#818 from bzz/ZEPPELIN-783-stable-ci-part-2 and squashes the following commits: b4d66b3 [Alexander Bezzubov] ZEPPELIN-783: advanced Spark download failover procedure
### What is this PR for? Shiro authentication dialog does not appear This is with reference with shiro authentication dialog not showing up on the mail thread. https://mail-archives.apache.org/mod_mbox/incubator-zeppelin-users/201603.mbox/%3CCALf24sbx9tY-hSXR7zhGXuAirWujn20Sc9CoZnLBmeBt_NbhDwmail.gmail.com%3E ### What type of PR is it? Bug Fix ### Todos * [x] - add ServletContextHandler filter for IniShiroFilter ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-797 ### How should this be tested? Run zeppelin-server from `zeppelin-distribution/target/zeppelin-0.6.0-incubating-SNAPSHOT/zeppelin-0.6.0-incubating-SNAPSHOT/` It should honour the `shiro.ini` located inside `zeppelin-distribution/target/zeppelin-0.6.0-incubating-SNAPSHOT/zeppelin-0.6.0-incubating-SNAPSHOT/conf/` ### Screenshots (if appropriate) N/A ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: Prabhjyot Singh <[email protected]> Closes apache#824 from prabhjyotsingh/ZEPPELIN-797 and squashes the following commits: 24a8e54 [Prabhjyot Singh] get shiro path from conf.getShiroPath() 8d0704a [Prabhjyot Singh] remove IniShiroFilter as it is depricated a82a9c8 [Prabhjyot Singh] ZEPPELIN-797: Shiro authentication dialog does not appear
### What is this PR for? This PR is to improve the result output when having interpreter streaming running. If you navigate outside the notebook, then come back inside, the streaming output will append below previous result. ### What type of PR is it? Improvement ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-772 ### How should this be tested? You can run this ``` (1 to 40).foreach{ i=> Thread.sleep(1000) println("Hello " + i) } ``` Then navigate to home, then back to the notebook. You should see the newly streamed result only. ### Screenshots Before:  After:  ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Damien CORNEAU <[email protected]> Closes apache#804 from corneadoug/improve/flushStreamingOutput and squashes the following commits: 76a66a4 [Damien CORNEAU] Flush on first text append event
### What is this PR for? Generate unique temporary files for Python and R Spark interpreters using java.io.File.createTempFile. Remove the temporary file for the Python interpreter when the interpreter is closed (is already being done in the R interpreter). Without this fix it is not possible to run more than one Zeppelin interpreter on the same server due to file owner conflicts between instances. ### What type of PR is it? Bug Fix ### Todos ### What is the Jira issue? No Jira opened for this ### How should this be tested? ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: Johan Muedsam <[email protected]> Closes apache#823 from mudsam/master and squashes the following commits: 0c018b4 [Johan Muedsam] Generate unique temporary files for Python and R Spark Interpreters. Add cleanup of Python temporary file on close().
Contributor
Author
|
@felixcheung, @Leemoonsoo: |
… if exists
### What is this PR for?
Replace dynamic form with angular object from registry if exists
I updated the `Paragraph.jobRun()` method to look for existing variable from the Angular Object Registry first before displaying the dynamic form.
We look for Angular object having same name:
* first at paragraph scope (note id + paragraph id)
* then at note scope (note id only)
I did not look at **global** scope because Leemoonsoo was mentioning somewhere that we may likely remove the global scope some day
_This is a sub-task of epic **[ZEPPELIN-635]**_
### What type of PR is it?
[Improvement]
### Todos
* [ ] - Code Review
* [ ] - Simple Test
### Is there a relevant Jira issue?
**[ZEPPELIN-697]**
### How should this be tested?
* `git fetch origin pull/745/head:AngularObjectReplaceDynamicFormVar`
* `git checkout AngularObjectReplaceDynamicFormVar`
* `mvn clean package -DskipTests`
* `bin/zeppelin-daemon.sh restart`
* Create a new note
* In the first paragraph, put the following code
```html
%angular
<form class="form-inline">
<div class="form-group">
<label for="superheroId">Super Hero: </label>
<input type="text" class="form-control" id="superheroId" placeholder="Superhero name ..." ng-model="superhero"></input>
</div>
<button type="submit" class="btn btn-primary" ng-click="z.angularBind('superhero', superhero, 'PUT_HERE_PARAGRAPH_ID'); z.runParagraph('PUT_HERE_PARAGRAPH_ID')"> Bind</button>
<button type="submit" class="btn btn-primary" ng-click="z.angularUnbind('superhero','PUT_HERE_PARAGRAPH_ID'); z.runParagraph('PUT_HERE_PARAGRAPH_ID')"> Unbind</button>
</form>
</form>
```
* Create a second paragraph with the following code:
```scala
%md
### The superhero is : **${superhero}**
```
* In the first paragraph, replace the text PUT_HERE_PARAGRAPH_ID by the paragraph id of the second paragraph
* Execute first the second paragraph to see that the dynamic form system is working as usual
* Now put **Batman** in the input text of the first paragraph and click alternatively on **Bind** to see that dynamic form in the second paragraph is removed
* Click on **Unbind** to see that the dynamic form system is back
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? --> **No**
* Is there breaking changes for older versions? --> **Yes**
* Does this needs documentation? --> **Yes**
[ZEPPELIN-635]: https://issues.apache.org/jira/browse/ZEPPELIN-635
[ZEPPELIN-697]: https://issues.apache.org/jira/browse/ZEPPELIN-697
Author: DuyHai DOAN <[email protected]>
Closes apache#745 from doanduyhai/ZEPPELIN-697 and squashes the following commits:
be4dbd1 [DuyHai DOAN] [ZEPPELIN-697] Replace dynamic form with angular object from registry if exists
### What is this PR for? Change system.out and system.err into logger.info ### What type of PR is it? [Improvement] ### Todos * [x] - Fixed to remove system.out and system.err ### What is the Jira issue? This is very trivial and minor issue ### How should this be tested? Check your logs/zeppelin*.out to see "------ Create new SparkContext ..." Apply this patch Check your logs/zeppelin*.log to see "------ Create new SparkContext ..." ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Jongyoul Lee <[email protected]> Closes apache#829 from jongyoul/minor-remove-stdout-stderr and squashes the following commits: f703fe3 [Jongyoul Lee] [Minor] - Revert test code 180e2c1 [Jongyoul Lee] [MINOR] - Change System.out and System.err into logger.info
…licitly ### What is this PR for? Set log4j into JVM option for enforcing logging configuration. ### What type of PR is it? [Bug Fix] ### Todos * [x] - Set "-Dlog4j.configuration=..." into JVM option ### What is the Jira issue? Minor issue ### How should this be tested? 1. Run spark with default log4j setting and check logs/zeppelin*.out. you can see logs from Spark. 1. Apply this patch. 1. Run spark with default log4j setting and check logs/zeppelin-interpreter*.log. you can see logs from Spark. ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Jongyoul Lee <[email protected]> Closes apache#830 from jongyoul/minor-set-log4j-explicitly and squashes the following commits: 2185284 [Jongyoul Lee] [MINOR] - Added "-Dlog4j.configuration" into JAVA_OPTS and JAVA_INTP_OPTS explicitly
### What is this PR for? support python edit mode in paragraph. ### What type of PR is it? Improvement ### Todos * [x] - support python edit mode. ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-799 ### How should this be tested? you can refer to screenshot. ### Screenshots (if appropriate) - before  - after  ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: hsshim <[email protected]> Closes apache#825 from astroshim/ZEPPELIN-799 and squashes the following commits: c0d579d [hsshim] fixed for a new interpreter group. 63af8ad [hsshim] add spark.pyspark condition. b2e23de [hsshim] add python edit mode.
Member
|
@fireboy1919 Thanks for the contribution. It looks like individual interpreter setting can configure ResourcePool implementation through it's property And how about add new configuration into ZeppelinConfiguration to set default value of resourcePoolClass globally through conf/zeppelin-env.sh and conf/zeppelin-site.xml ? |
Contributor
Author
|
Great ideas! Since interpreters don't directly use the Zeppelin Configuration, I'll pass it along by adding it as a property within InterpreterFactory. Does that seem like a reasonable implementation? |
Contributor
Author
|
The implementation that I suggested has been implemented. I did it by actually including all of the things that are in zeppelinconfig that start with zeppelin.interpreter into the properties list. |
Member
|
Somehow, the PR includes commits from other contributions. @fireboy1919 could you manage it to not includes them? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
This is a step towards creating a REST endpoint from resource pools https://issues.apache.org/jira/browse/ZEPPELIN-699
It allows resources to be saved to disk so that they can be reloaded.
What type of PR is it?
Improvement
Todos
What is the Jira issue?
Partially implements this: https://issues.apache.org/jira/browse/ZEPPELIN-699
Note, that this pull request is dependent upon this one:
#782
How should this be tested?
You should see new resource files created in notebook/zeppelin_resources
Screenshots (if appropriate)
Questions: