Skip to content

[ZEPPELIN-789] Skip execution of a paragraph in case of error #812

Closed
ghost wants to merge 3 commits intoapache:masterfrom
egen:skipOnError
Closed

[ZEPPELIN-789] Skip execution of a paragraph in case of error #812
ghost wants to merge 3 commits intoapache:masterfrom
egen:skipOnError

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Apr 4, 2016

What is this PR for?

New option in paragraphs to skip execution, when notebook is executed as a whole and there were some errors in execution of the previous paragraphs.
More details in jira ticket https://issues.apache.org/jira/browse/ZEPPELIN-789

What type of PR is it?

Improvement

Todos

What is the Jira issue?

How should this be tested?

  • Build this PR
  • Create a notebook and add three paragraphs in it
  • Make sure the first paragraph results in error. Easy way is to have syntax error
  • Add some print statement in second paragraph and set skipOnError to true for second paragraph
  • Add some more print in third paragraph
  • Execute the notebook. Second paragraph execution should be skipped.
  • Now set skipOnError to false in second paragraph and execute the notebook. It should be executed as well.

Screenshots (if appropriate)

skiponerror

Questions:

  • Does the licenses files need update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? Yes

@ghost
Copy link
Copy Markdown
Author

ghost commented Apr 4, 2016

We have some tests failing in this PR. But we are not getting any details of the failure.

Below is the error that we see

No output has been received in the last 10 minutes, this potentially indicates a stalled build or something wrong with the build itself.

The build has been terminated

How can we find more information to solve these test issues? Are these test failures caused by the code changes present in this PR?

@felixcheung
Copy link
Copy Markdown
Member

felixcheung commented Apr 16, 2016

Does not seem like it, could you please close and reopen this PR to kick off Travis CI again?

@ghost ghost closed this Apr 18, 2016
@ghost
Copy link
Copy Markdown
Author

ghost commented Apr 18, 2016

Reopening as requested

@ghost ghost reopened this Apr 18, 2016
@ghost
Copy link
Copy Markdown
Author

ghost commented Apr 18, 2016

Again same error. There might be some issue with this PR. But how can I find it?

@ghost ghost closed this Apr 20, 2016
@ghost ghost reopened this Apr 20, 2016
@khalidhuseynov
Copy link
Copy Markdown
Member

khalidhuseynov commented May 19, 2016

Could you reopen PR to trigger CI? The build failure doesn't seem to be related

@ghost ghost closed this May 19, 2016
@ghost ghost reopened this May 19, 2016
@corneadoug
Copy link
Copy Markdown
Contributor

corneadoug commented Oct 3, 2016

@springml If we still want to continue this PR, there might be a few things to consider.
When running the whole paragraph, there is no specific paragraph running order. Depending on the interpreter used, some will start before others. Because of that, I'm not sure if this feature would really be functional.

@asfgit asfgit closed this in c38a0a0 May 9, 2018
asfgit pushed a commit that referenced this pull request May 9, 2018
@jongyoul
Close outdated PRs
b11d355 
close #83
close #86
close #125
close #133
close #139
close #146
close #193
close #203
close #246
close #262
close #264
close #273
close #291
close #299
close #320
close #347
close #389
close #413
close #423
close #543
close #560
close #658
close #670
close #728
close #765
close #777
close #782
close #783
close #812
close #822
close #841
close #843
close #878
close #884
close #918
close #989
close #1076
close #1135
close #1187
close #1231
close #1304
close #1316
close #1361
close #1385
close #1390
close #1414
close #1422
close #1425
close #1447
close #1458
close #1466
close #1485
close #1492
close #1495
close #1497
close #1536
close #1545
close #1561
close #1577
close #1600
close #1603
close #1678
close #1695
close #1739
close #1748
close #1765
close #1767
close #1776
close #1783
close #1799
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@felixcheung @khalidhuseynov @corneadoug @samuel-pt