ZEPPELIN-672] Add Datatables instead of normal tables by ankurmitujjain · Pull Request #761 · apache/zeppelin

ankurmitujjain · 2016-03-04T11:21:17Z

What is this PR for?

It is an extension of #6 #714
It allows user to export data in a paragraph to a TSV/CSV file.

What type of PR is it?

Feature

Todos

- Improves the current Table features like Search, Fixed Headers, Sorting

Is there a relevant Jira issue?

ZEPPELIN-672

How should this be tested?

Create a paragraph with data in %table view
Click on TSV/CSV button to export CSV/TSV file

Screenshots (if appropriate)

Questions:

Does the licenses files need update?
Need to have MIT license for Datatables.
Is there breaking changes for older versions?
No
Does this needs documentation?
No

Signed-off-by: ankur_jain <[email protected]>

…ch box.

ankurmitujjain · 2016-03-04T13:19:42Z

@adejanovski @corneadoug @bzz @Leemoonsoo
I am done with integrating datatables, have to update a failing testcase...

@corneadoug can you please let me know any example for Chart Pivoted data to verify if this is completed or not...

Thanks
Ankur

ankurmitujjain · 2016-03-10T06:02:08Z

@adejanovski @corneadoug @bzz @Leemoonsoo @felixcheung

Hello Team,

Can you please review this PR?

Thanks
Ankur

corneadoug · 2016-03-10T10:05:15Z

Thanks, I'll test that out

prabhjyotsingh · 2016-03-11T06:30:10Z

I see following issues:

There is a horizontal scrollbar
When i scroll, table data goes above header

ankurmitujjain · 2016-03-14T05:49:18Z

Thanks for reviewing @prabhjyotsingh
-I will look into horizontal scroll bar

Thanks
Ankur

--There is a horizontal scrollbar --When i scroll, table data goes above header Signed-off-by: ankur_jain <[email protected]>

ankurmitujjain · 2016-03-14T09:48:55Z

Hi @prabhjyotsingh ,

I had updated code as per your comments please review..

Thanks
Ankur

prabhjyotsingh · 2016-03-14T17:02:22Z

Tested it with different size of data. Looks good to me.

ankurmitujjain · 2016-03-15T12:59:04Z

Hi @corneadoug can we merge it ?

felixcheung · 2016-03-15T18:00:55Z

@hyonaldo @zhongneu you have both created PRs on this before, are you ok with this approach?

corneadoug · 2016-03-16T05:20:30Z

I found some css problems depending on the paragraph size:

Also, when we scroll, the download buttons and search input can't be seen:

Btw, I saw that the Allowing Export to be not only Table based, but also of Chart Pivoted data task is checked, however I didn't see any button when switching to a graph

ankurmitujjain · 2016-03-17T19:17:40Z

Hi @corneadoug : Sorry I wrongly marked pivot chart data as complete...
Actually I have to remove that feature for now, I will be exploring on how we can export data from graphs as per you suggestion, but for now I would like to keep this feature away from this PR...

However we can always export graph data in table view.

This PR I had planned only for implementing datatable and its export feature....
Please let me know if you are ok with this...

Regarding CSS problem: I will look into it...

Thanks
Ankur

jmrr · 2016-04-05T09:17:46Z

@ankurjainyash any progress with this? I'm experiencing some merge conflicts and master is evolving fast.

@Leemoonsoo I've seen that the export capability is clearly set in the roadmap you sent few weeks ago. What do you think it will be the final approach? Any of #725 , #714 , #6 #89 or #672 or a combination of some/all? I've tested #672 and its data display with search/sort seems more complete.

corneadoug · 2016-04-05T09:26:03Z

I think we would be better off using multiple PRs:

ZEPPELIN-672] Add Datatables instead of normal tables #761 to replace the table only (if it brings better performances)
Exporting to TSV #714 to have a download button available at all time for front data
Added CSV and Tableau export functionality #725 to have a download button available at all time for back-end data

The good thing would be that both back-end and front-end data download would use the same UI, and it wouldn't add additional UI elements in the view

r-kamath · 2016-04-05T11:53:48Z

#761 to replace the table only (if it brings better performances)

What is the max number of rows this lib can support ?

…/master

…zeppelin

Conflicts: zeppelin-web/src/app/notebook/paragraph/paragraph.css

This reverts commit adb66a3, reversing changes made to 6363e97. Conflicts: conf/zeppelin-site.xml.template zeppelin-zengine/src/main/java/org/apache/zeppelin/conf/ZeppelinConfiguration.java

Signed-off-by: ankur_jain <[email protected]>

Conflicts: docs/interpreter/R.md zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js zeppelin-web/src/app/notebook/paragraph/paragraph.css

ankurmitujjain · 2016-04-12T06:33:59Z

@corneadoug , please also review comments from other users... #6.

fireboy1919 · 2016-04-13T14:11:58Z

See: #822

corneadoug · 2016-04-14T01:41:14Z

@ankurmitujjain I made a PR to your branch ankurmitujjain#1

ankurmitujjain · 2016-04-14T03:18:38Z

@fireboy1919 is it possible to download output in the form of CSV/TSV?

fireboy1919 · 2016-04-14T13:27:58Z

Yes, #822 does that. It's purely backend, using resource pools. You might consider it an alternative to using #714.

ankurmitujjain · 2016-04-14T13:29:54Z

ok if thats the case than I believe datatable dont need download functionality which will be handled by #822 . please correct me if I am wrong...

ankurmitujjain · 2016-04-14T13:32:29Z

@fireboy1919 is it possible to download both server side data and front end table data?

fireboy1919 · 2016-04-14T18:46:18Z

It's a REST call, so potentially, you could make a client side call to combine the two pieces of information.

But the problem is the same one the backend is solving by being backend - the memory limits imposed by the browser are small compared to what the server can handle.

A smarter approach would probably be to get that kind of thing would be to make a different kind backend component that can transform the data the way that you want it to be transformed.

ankurmitujjain · 2016-04-15T06:31:09Z

So basically you are suggesting to use rest endpoints in download buttons to download server side data....

@corneadoug

Merging changes provided by @corneadoug

darionyaphet · 2016-04-15T08:46:58Z

hi @ankurjainyash could support a option about save the CSV/TSV to server ? It's very useful .

ankurmitujjain · 2016-04-15T10:27:10Z

@darionyaphet . If you want to save data as csv on server you can use below code...

spark-csv

 val selectedData = df.select("year", "model")
 selectedData.write
.format("com.databricks.spark.csv")
.option("header", "true")
.save("newcars.csv")

darionyaphet · 2016-04-15T10:34:32Z

@ankurmitujjain 👍

@corneadoug

Updated testcases for @corneadoug pull request

ankurmitujjain · 2016-04-20T12:21:26Z

Updated code to fix testcase, please review

corneadoug · 2016-04-27T08:53:55Z

Merging this

felixcheung · 2016-04-27T15:46:27Z

Could you check out #858? Seems to overlap with this PR
#858

corneadoug · 2016-04-28T02:47:38Z

@felixcheung already saw it and I will check it.
However, while we test + discuss the other PR, there is no reason not to merge this one.
If the other is better, then it can simply replace this one

### What is this PR for? After #761, on compiling project this file `karma.conf.js` started showing diff. ### What type of PR is it? [Hot Fix] ### Todos * [x] - Add karma.conf.js with diff. ### What is the Jira issue? N/A ### How should this be tested? ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: Prabhjyot Singh <[email protected]> Closes #875 from prabhjyotsingh/datatables_missing_karam_conf and squashes the following commits: f313878 [Prabhjyot Singh] add missing karma.conf.js

@corneadoug

### What is this PR for? It is an extension of apache#6 apache#714 It allows user to export data in a paragraph to a TSV/CSV file. ### What type of PR is it? Feature ### Todos * [x] - Improves the current Table features like Search, Fixed Headers, Sorting ### Is there a relevant Jira issue? [ZEPPELIN-672](https://issues.apache.org/jira/browse/ZEPPELIN-672) ### How should this be tested? 1. Create a paragraph with data in %table view 2. Click on TSV/CSV button to export CSV/TSV file ### Screenshots (if appropriate) ![image](https://cloud.githubusercontent.com/assets/1140475/13525760/4913bd8e-e229-11e5-9cd5-480c8b583d5b.png) ### Questions: * Does the licenses files need update? Need to have MIT license for Datatables. * Is there breaking changes for older versions? No * Does this needs documentation? No Author: ankur_jain <[email protected]> Author: Ankur Jain <[email protected]> Author: Damien CORNEAU <[email protected]> Closes apache#761 from ankurmitujjain/master and squashes the following commits: 4ddcc0f [Ankur Jain] Updated testcases for @corneadoug pull request e6470aa [Ankur Jain] Merge pull request apache#1 from corneadoug/clean/dataframe dd8901b [Damien CORNEAU] last fixes 5aca081 [Damien CORNEAU] Last Modifications 9c4412f [Damien CORNEAU] Remove buttons 2561630 [Ankur Jain] Updated for indent c9b675d [Ankur Jain] Updated for indent 38ee3c3 [Ankur Jain] Updated for indent b23cab4 [Ankur Jain] Updated for indent 09c87a0 [Ankur Jain] Updated for indent e4b3abb [ankur_jain] Removed R.md accidentally added d3aadc6 [ankur_jain] Updated testcase 210b7a6 [ankur_jain] Updates latest code of controller 80bd58c [ankur_jain] Merge branch 'upstream/master' 0ee76b1 [ankur_jain] Update 3 files 0c5f623 [ankur_jain] Revert "Merge branch 'upstream/master'" adb66a3 [ankur_jain] Merge branch 'upstream/master' 6363e97 [ankur_jain] Merge branch 'master' of https://github.com/ankurmitujjain/incubator-zeppelin 0c94cab [ankur_jain] Merge branch 'master' of https://github.com/ankurmitujjain/incubator-zeppelin d23202e [ankur_jain] Merge remote-tracking branch 'refs/remotes/origin/master' into apache/master 415c1f5 [ankur_jain] Merge branch 'apache/master' 7901f5e [ankur_jain] Merge branch 'refs/heads/master' into apache/master 6e6587b [ankur_jain] Updating codebase as per @prabhjyotsingh comments aea8446 [ankur_jain] Merge branch 'apache/master' df1620c [ankur_jain] Updated testcase as resultant paragraph have text of buttons and search box. 00b36e5 [ankur_jain] Reverted line 117 and 2122 as per previous code 9351a0d [ankur_jain] Committed for Datatables apache#6

### What is this PR for? After apache#761, on compiling project this file `karma.conf.js` started showing diff. ### What type of PR is it? [Hot Fix] ### Todos * [x] - Add karma.conf.js with diff. ### What is the Jira issue? N/A ### How should this be tested? ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: Prabhjyot Singh <[email protected]> Closes apache#875 from prabhjyotsingh/datatables_missing_karam_conf and squashes the following commits: f313878 [Prabhjyot Singh] add missing karma.conf.js

darionyaphet · 2016-06-08T03:12:23Z

This PR have merge into master branch ? @ankurmitujjain @prabhjyotsingh

AhyoungRyu · 2016-06-08T21:19:54Z

@darionyaphet Yes it does. See here : d481b56

ankur-jain-yash added 3 commits March 4, 2016 16:13

Committed for Datatables apache#6

9351a0d

Signed-off-by: ankur_jain <[email protected]>

Reverted line 117 and 2122 as per previous code

00b36e5

Signed-off-by: ankur_jain <[email protected]>

Updated testcase as resultant paragraph have text of buttons and sear…

df1620c

…ch box.

ankurmitujjain changed the title ~~Add feature to export tables using Datatables~~ [ZEPPELIN-672] Add feature to export tables using Datatables Mar 4, 2016

ankurmitujjain mentioned this pull request Mar 6, 2016

add features to export table #6

Closed

ankur-jain-yash added 2 commits March 14, 2016 14:40

Merge branch 'apache/master'

aea8446

Updating codebase as per @prabhjyotsingh comments

6e6587b

--There is a horizontal scrollbar --When i scroll, table data goes above header Signed-off-by: ankur_jain <[email protected]>

Merge branch 'refs/heads/master' into apache/master

7901f5e

Merge branch 'apache/master'

415c1f5

ankur-jain-yash added 7 commits April 6, 2016 16:14

Merge remote-tracking branch 'refs/remotes/origin/master' into apache…

d23202e

…/master

Merge branch 'master' of https://github.com/ankurmitujjain/incubator-…

0c94cab

…zeppelin

Merge branch 'master' of https://github.com/ankurmitujjain/incubator-…

6363e97

…zeppelin

Merge branch 'upstream/master'

adb66a3

Conflicts: zeppelin-web/src/app/notebook/paragraph/paragraph.css

Revert "Merge branch 'upstream/master'"

0c5f623

This reverts commit adb66a3, reversing changes made to 6363e97. Conflicts: conf/zeppelin-site.xml.template zeppelin-zengine/src/main/java/org/apache/zeppelin/conf/ZeppelinConfiguration.java

Update 3 files

0ee76b1

Signed-off-by: ankur_jain <[email protected]>

Merge branch 'upstream/master'

80bd58c

Conflicts: docs/interpreter/R.md zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js zeppelin-web/src/app/notebook/paragraph/paragraph.css

last fixes

dd8901b

Merge pull request #1 from corneadoug/clean/dataframe

e6470aa

Merging changes provided by @corneadoug

Updated testcases for @corneadoug pull request

4ddcc0f

Updated testcases for @corneadoug pull request

johnnyws mentioned this pull request Apr 19, 2016

Exporting to TSV #714

Closed

4 tasks

felixcheung mentioned this pull request Apr 26, 2016

ZEPPELIN-830 Improve table display to handle large data #858

Closed

4 tasks

asfgit closed this in d481b56 Apr 30, 2016

prabhjyotsingh mentioned this pull request May 5, 2016

[Hot Fix] add missing karma.conf.js #875

Closed

1 task

jmrr mentioned this pull request May 9, 2016

Added CSV and Tableau export functionality #725

Closed

ankurmitujjain changed the title ~~[ZEPPELIN-672] Add feature to export tables using Datatables~~ ZEPPELIN-672] Add Datatables instead of normal tables Jun 8, 2016

Conversation

ankurmitujjain commented Mar 4, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What is this PR for?

What type of PR is it?

Todos

Is there a relevant Jira issue?

How should this be tested?

Screenshots (if appropriate)

Questions:

Uh oh!

ankurmitujjain commented Mar 4, 2016

Uh oh!

ankurmitujjain commented Mar 10, 2016

Uh oh!

corneadoug commented Mar 10, 2016

Uh oh!

prabhjyotsingh commented Mar 11, 2016

Uh oh!

ankurmitujjain commented Mar 14, 2016

Uh oh!

ankurmitujjain commented Mar 14, 2016

Uh oh!

prabhjyotsingh commented Mar 14, 2016

Uh oh!

ankurmitujjain commented Mar 15, 2016

Uh oh!

felixcheung commented Mar 15, 2016

Uh oh!

corneadoug commented Mar 16, 2016

Uh oh!

ankurmitujjain commented Mar 17, 2016

Uh oh!

jmrr commented Apr 5, 2016

Uh oh!

corneadoug commented Apr 5, 2016

Uh oh!

r-kamath commented Apr 5, 2016

Uh oh!

ankurmitujjain commented Apr 12, 2016

Uh oh!

fireboy1919 commented Apr 13, 2016

Uh oh!

corneadoug commented Apr 14, 2016

Uh oh!

ankurmitujjain commented Apr 14, 2016

Uh oh!

fireboy1919 commented Apr 14, 2016

Uh oh!

ankurmitujjain commented Apr 14, 2016

Uh oh!

ankurmitujjain commented Apr 14, 2016

Uh oh!

fireboy1919 commented Apr 14, 2016

Uh oh!

ankurmitujjain commented Apr 15, 2016

Uh oh!

darionyaphet commented Apr 15, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ankurmitujjain commented Apr 15, 2016

Uh oh!

darionyaphet commented Apr 15, 2016

Uh oh!

ankurmitujjain commented Apr 20, 2016

Uh oh!

corneadoug commented Apr 27, 2016

Uh oh!

felixcheung commented Apr 27, 2016

Uh oh!

corneadoug commented Apr 28, 2016

Uh oh!

darionyaphet commented Jun 8, 2016

Uh oh!

AhyoungRyu commented Jun 8, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

ankurmitujjain commented Mar 4, 2016 •

edited

Loading

darionyaphet commented Apr 15, 2016 •

edited

Loading