Closed
Conversation
1 task
Contributor
|
@zhongneu Tested after rebasing with master, no conflicts. |
Contributor
|
@zhongneu Could you rebase? |
Contributor
|
@corneadoug are you sure you want to merge this? I thought we were working on #761? There are still pending TODOs in this PR. I don't think we should merge it before finish them. |
Contributor
|
It was already discussed there. If we get this done with, then we can work on improving it, and build around it. |
|
@corneadoug I think its not right/user friendly way to have download data functionality. You liked approach of including download buttons in "settings". Also @adejanovski #6 commented rightly that
So I believe it's not a good idea to include buttons in settings as many community member don't liked it. Secondly if DataTables provides export functionality which works and is extensible, than we should use it instead of writing our own way to do data export, this I mentioned earlier as well... #6 Also about extra UI space, its not an issue for using datatable or any of its functionality, but its general issue and to fix it we need to have a different PR... If I look different notebook implementation, than the way they handle this issue is like below...
|
4 tasks
asfgit
pushed a commit
that referenced
this pull request
Apr 30, 2016
### What is this PR for? It is an extension of #6 #714 It allows user to export data in a paragraph to a TSV/CSV file. ### What type of PR is it? Feature ### Todos * [x] - Improves the current Table features like Search, Fixed Headers, Sorting ### Is there a relevant Jira issue? [ZEPPELIN-672](https://issues.apache.org/jira/browse/ZEPPELIN-672) ### How should this be tested? 1. Create a paragraph with data in %table view 2. Click on TSV/CSV button to export CSV/TSV file ### Screenshots (if appropriate)  ### Questions: * Does the licenses files need update? Need to have MIT license for Datatables. * Is there breaking changes for older versions? No * Does this needs documentation? No Author: ankur_jain <[email protected]> Author: Ankur Jain <[email protected]> Author: Damien CORNEAU <[email protected]> Closes #761 from ankurmitujjain/master and squashes the following commits: 4ddcc0f [Ankur Jain] Updated testcases for @corneadoug pull request e6470aa [Ankur Jain] Merge pull request #1 from corneadoug/clean/dataframe dd8901b [Damien CORNEAU] last fixes 5aca081 [Damien CORNEAU] Last Modifications 9c4412f [Damien CORNEAU] Remove buttons 2561630 [Ankur Jain] Updated for indent c9b675d [Ankur Jain] Updated for indent 38ee3c3 [Ankur Jain] Updated for indent b23cab4 [Ankur Jain] Updated for indent 09c87a0 [Ankur Jain] Updated for indent e4b3abb [ankur_jain] Removed R.md accidentally added d3aadc6 [ankur_jain] Updated testcase 210b7a6 [ankur_jain] Updates latest code of controller 80bd58c [ankur_jain] Merge branch 'upstream/master' 0ee76b1 [ankur_jain] Update 3 files 0c5f623 [ankur_jain] Revert "Merge branch 'upstream/master'" adb66a3 [ankur_jain] Merge branch 'upstream/master' 6363e97 [ankur_jain] Merge branch 'master' of https://github.com/ankurmitujjain/incubator-zeppelin 0c94cab [ankur_jain] Merge branch 'master' of https://github.com/ankurmitujjain/incubator-zeppelin d23202e [ankur_jain] Merge remote-tracking branch 'refs/remotes/origin/master' into apache/master 415c1f5 [ankur_jain] Merge branch 'apache/master' 7901f5e [ankur_jain] Merge branch 'refs/heads/master' into apache/master 6e6587b [ankur_jain] Updating codebase as per @prabhjyotsingh comments aea8446 [ankur_jain] Merge branch 'apache/master' df1620c [ankur_jain] Updated testcase as resultant paragraph have text of buttons and search box. 00b36e5 [ankur_jain] Reverted line 117 and 2122 as per previous code 9351a0d [ankur_jain] Committed for Datatables #6
onkarshedge
pushed a commit
to onkarshedge/incubator-zeppelin
that referenced
this pull request
May 11, 2016
### What is this PR for? It is an extension of apache#6 apache#714 It allows user to export data in a paragraph to a TSV/CSV file. ### What type of PR is it? Feature ### Todos * [x] - Improves the current Table features like Search, Fixed Headers, Sorting ### Is there a relevant Jira issue? [ZEPPELIN-672](https://issues.apache.org/jira/browse/ZEPPELIN-672) ### How should this be tested? 1. Create a paragraph with data in %table view 2. Click on TSV/CSV button to export CSV/TSV file ### Screenshots (if appropriate)  ### Questions: * Does the licenses files need update? Need to have MIT license for Datatables. * Is there breaking changes for older versions? No * Does this needs documentation? No Author: ankur_jain <[email protected]> Author: Ankur Jain <[email protected]> Author: Damien CORNEAU <[email protected]> Closes apache#761 from ankurmitujjain/master and squashes the following commits: 4ddcc0f [Ankur Jain] Updated testcases for @corneadoug pull request e6470aa [Ankur Jain] Merge pull request apache#1 from corneadoug/clean/dataframe dd8901b [Damien CORNEAU] last fixes 5aca081 [Damien CORNEAU] Last Modifications 9c4412f [Damien CORNEAU] Remove buttons 2561630 [Ankur Jain] Updated for indent c9b675d [Ankur Jain] Updated for indent 38ee3c3 [Ankur Jain] Updated for indent b23cab4 [Ankur Jain] Updated for indent 09c87a0 [Ankur Jain] Updated for indent e4b3abb [ankur_jain] Removed R.md accidentally added d3aadc6 [ankur_jain] Updated testcase 210b7a6 [ankur_jain] Updates latest code of controller 80bd58c [ankur_jain] Merge branch 'upstream/master' 0ee76b1 [ankur_jain] Update 3 files 0c5f623 [ankur_jain] Revert "Merge branch 'upstream/master'" adb66a3 [ankur_jain] Merge branch 'upstream/master' 6363e97 [ankur_jain] Merge branch 'master' of https://github.com/ankurmitujjain/incubator-zeppelin 0c94cab [ankur_jain] Merge branch 'master' of https://github.com/ankurmitujjain/incubator-zeppelin d23202e [ankur_jain] Merge remote-tracking branch 'refs/remotes/origin/master' into apache/master 415c1f5 [ankur_jain] Merge branch 'apache/master' 7901f5e [ankur_jain] Merge branch 'refs/heads/master' into apache/master 6e6587b [ankur_jain] Updating codebase as per @prabhjyotsingh comments aea8446 [ankur_jain] Merge branch 'apache/master' df1620c [ankur_jain] Updated testcase as resultant paragraph have text of buttons and search box. 00b36e5 [ankur_jain] Reverted line 117 and 2122 as per previous code 9351a0d [ankur_jain] Committed for Datatables apache#6
Contributor
|
Merging this if no more discussions. |
asfgit
pushed a commit
that referenced
this pull request
Jun 10, 2016
### What is this PR for? Following the PR #714 and its comments, we are moving the download data outside the paragraph settings. Which would allow a possible drop down to choose backend data download in the future. ### What type of PR is it? Improvement ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-975 ### How should this be tested? Show a %Table type of result (you can use below code in a paragraph for that). You should see the icon, click on it to download the data. ``` print(s"""%table name\tsize sun\t127.6 moon\t0.6458 gerard\t45.234856803""") ``` ### Screenshots (if appropriate)  ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No, but maybe feature announcement during release Author: Damien CORNEAU <[email protected]> Closes #975 from corneadoug/improve/downloadDataBtnVisibility and squashes the following commits: 2ca3028 [Damien CORNEAU] Move download data button outside the paragraph settings
asfgit
pushed a commit
that referenced
this pull request
Jun 16, 2016
### What is this PR for? Add csv download from front-end leveraging #714 ### What type of PR is it? Improvement ### What is the Jira issue? [ZEPPELIN-997](https://issues.apache.org/jira/browse/ZEPPELIN-997) ### Screenshots (if appropriate) **Before** <img width="347" alt="screen shot 2016-06-13 at 4 55 02 pm" src="https://cloud.githubusercontent.com/assets/8503346/16027024/acb80824-3187-11e6-8535-090b06e4807e.png"> **After** <img width="354" alt="screen shot 2016-06-14 at 12 42 01 am" src="https://cloud.githubusercontent.com/assets/8503346/16034849/dd6f48c4-31c8-11e6-92b8-809b3f27d429.png"> <img width="357" alt="screen shot 2016-06-14 at 12 41 49 am" src="https://cloud.githubusercontent.com/assets/8503346/16034844/da6cef46-31c8-11e6-8ef2-d11c460eaa02.png"> ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Mina Lee <[email protected]> Closes #1008 from minahlee/ZEPPELIN-997 and squashes the following commits: dabb603 [Mina Lee] Add tooltip and change style for dropdown button e48c303 [Mina Lee] Fix integration test after adding csv download button 5437c4f [Mina Lee] Use split button dropdowns for downloading data 2ad6f47 [Mina Lee] Export data to csv
asfgit
pushed a commit
that referenced
this pull request
Jun 25, 2016
### What is this PR for? Add csv download from front-end leveraging #714 ### What type of PR is it? Improvement ### What is the Jira issue? [ZEPPELIN-997](https://issues.apache.org/jira/browse/ZEPPELIN-997) ### Screenshots (if appropriate) **Before** <img width="347" alt="screen shot 2016-06-13 at 4 55 02 pm" src="https://cloud.githubusercontent.com/assets/8503346/16027024/acb80824-3187-11e6-8535-090b06e4807e.png"> **After** <img width="354" alt="screen shot 2016-06-14 at 12 42 01 am" src="https://cloud.githubusercontent.com/assets/8503346/16034849/dd6f48c4-31c8-11e6-92b8-809b3f27d429.png"> <img width="357" alt="screen shot 2016-06-14 at 12 41 49 am" src="https://cloud.githubusercontent.com/assets/8503346/16034844/da6cef46-31c8-11e6-8ef2-d11c460eaa02.png"> ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Mina Lee <[email protected]> Closes #1008 from minahlee/ZEPPELIN-997 and squashes the following commits: dabb603 [Mina Lee] Add tooltip and change style for dropdown button e48c303 [Mina Lee] Fix integration test after adding csv download button 5437c4f [Mina Lee] Use split button dropdowns for downloading data 2ad6f47 [Mina Lee] Export data to csv (cherry picked from commit 048e432) Signed-off-by: Mina Lee <[email protected]>
1 task
asfgit
pushed a commit
that referenced
this pull request
Jul 11, 2016
### What is this PR for? Fix chinese garbled open with Excel #714 ### What type of PR is it? Bug Fix ### Todos * [x] - Add Bom Header ### What is the Jira issue? [ZEPPELIN-672](https://issues.apache.org/jira/browse/ZEPPELIN-672) ### How should this be tested? create a paragraph with chinses chars data in %table view. download with CSV format and open with Excel. ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: ZhangEthan <[email protected]> Closes #1151 from cquptEthan/fonted-download-error-code-fix and squashes the following commits: a4a99b4 [ZhangEthan] Fix chinese garbled in Excel 46628c2 [ZhangEthan] Merge branch 'apache/master' into fonted-download-error-code-fix
asfgit
pushed a commit
that referenced
this pull request
Jul 11, 2016
### What is this PR for? Fix chinese garbled open with Excel #714 ### What type of PR is it? Bug Fix ### Todos * [x] - Add Bom Header ### What is the Jira issue? [ZEPPELIN-672](https://issues.apache.org/jira/browse/ZEPPELIN-672) ### How should this be tested? create a paragraph with chinses chars data in %table view. download with CSV format and open with Excel. ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: ZhangEthan <[email protected]> Closes #1151 from cquptEthan/fonted-download-error-code-fix and squashes the following commits: a4a99b4 [ZhangEthan] Fix chinese garbled in Excel 46628c2 [ZhangEthan] Merge branch 'apache/master' into fonted-download-error-code-fix (cherry picked from commit 513b8ab) Signed-off-by: Lee moon soo <[email protected]>
PhilippGrulich
pushed a commit
to SWC-SENSE/zeppelin
that referenced
this pull request
Aug 8, 2016
### What is this PR for? Fix chinese garbled open with Excel apache#714 ### What type of PR is it? Bug Fix ### Todos * [x] - Add Bom Header ### What is the Jira issue? [ZEPPELIN-672](https://issues.apache.org/jira/browse/ZEPPELIN-672) ### How should this be tested? create a paragraph with chinses chars data in %table view. download with CSV format and open with Excel. ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: ZhangEthan <[email protected]> Closes apache#1151 from cquptEthan/fonted-download-error-code-fix and squashes the following commits: a4a99b4 [ZhangEthan] Fix chinese garbled in Excel 46628c2 [ZhangEthan] Merge branch 'apache/master' into fonted-download-error-code-fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Allow users to export data in a paragraph to a TSV file.
There is already a PR for this, but it uses DataTables, which requires Flash.
What type of PR is it?
Feature
Todos
Is there a relevant Jira issue?
ZEPPELIN-672
How should this be tested?
Screenshots (if appropriate)
Questions:
NO
NO
NO