Conversation
if fromMessage.principal.equals("anonymous") then set user as null
f228b6d to
60e0a6e
Compare
60e0a6e to
320790c
Compare
|
This is a requisite first step for getting to multi-user scenarios. I believe this should get discussed a little bit in terms of approach. |
|
This is ready for review. |
|
@rconline how would you want to discuss? Should we open a JIRA - or a JIRA parent with subtests for this multi-user auth use cases? |
|
@prabhjyotsingh could you explain more on the reason for this change? |
|
@felixcheung @prabhjyotsingh The purpose of this discussion should be to get to an approach that allows us zeppelin to do a couple of things - pass user identity to the underlying spark cluster, and thereby support multi-tenancy. There is JIRA open - https://issues.apache.org/jira/browse/ZEPPELIN-645 which we could use to discuss this further. Does that make sense? |
|
I think it make sense to let access authentication info through InterpreterContext. So my suggestion is, create such class |
|
Thank you for the suggestion @Leemoonsoo. Have added AuthenticationInfo class, and made relevant changes. |
|
I have tried and it works well. |
|
Thanks you @Leemoonsoo, that does make a lot of sense. |
d955d62 to
033a354
Compare
|
Thanks @prabhjyotsingh. |
|
LGTM |
|
Let's rebase and merge this? |
…ntext # Conflicts: # zeppelin-server/src/test/java/org/apache/zeppelin/integration/ZeppelinIT.java
|
Thank you for reviewing this. Have merged this with master. |
What is this PR for?
The goal of the PR is to pass userName/userInfo from front-end to interpreters.
The PR uses Shiro authentication(#586).
What type of PR is it?
Improvement
Todos
Is there a relevant Jira issue?
N/A