ZEPPELIN-598 ] Dynamic loading for Interpreter#652
ZEPPELIN-598 ] Dynamic loading for Interpreter#652cloverhearts wants to merge 2 commits intoapache:masterfrom cloverhearts:ZEPPELIN-598
Conversation
There was a problem hiding this comment.
Could you also add this property to conf/zeppelin-env.sh.template, conf/zeppelin-site.xml.template and docs/install/install.md ?
There was a problem hiding this comment.
@Leemoonsoo Thank you for feed back.
I will add that information.
There was a problem hiding this comment.
I think the name ZEPPELIN_INTERPRETER_REPO_DIR and zeppelin.user.interpreter.dir are little bit confusing.
How about more intuitive name such as ZEPPELIN_INTERPRETER_DOWNLOAD_DIR and zeppelin.interpreter.download.dir ?
There was a problem hiding this comment.
If it's the temp directory for downloaded interpreter, why not making it more general like: ZEPPELIN_PLUGINS_DOWNLOAD_DIR?
There was a problem hiding this comment.
@corneadoug because Interpreter is loaded by conf/interpreter.sh and other pluggable component are not, copying dependencies in a directory is only requirement of conf/interpreter.sh. So this configuration shouldn't be generalized for other pluggable module.
Dependencies for other pluggable components will directly loaded from local repository for dependency loader, which is configured by ZEPPELIN_DEP_LOCALREPO.
|
Is it closed on purpose? |
3 participants
What is this PR for?
Use of external libraries that are included in the Roadmap,
The interpreter needs related to dynamic loading capabilities.
_It has been re-written from the first newly created PR._
#631
What type of PR is it?
Feature
Todos
Is there a relevant Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-598
How should this be tested?
By annotating the interpreter setting items below, try using the loadDynamicInterpreter method.
Or create a new interpreter loads created in the local Maven repository.
incubator-zeppelin/zeppelin-zengine/src/main/java/org/apache/zeppelin/conf/ZeppelinConfiguration.java
Questions: