keyboard shortcut to add above#643
Closed
TYMichaelChen wants to merge 2 commits intoapache:masterfrom
Closed
Conversation
Member
|
Thanks for the contribution. And I think it's good idea to reserve ctrl-alt-'n' and ctrl-alt-'p' for something related to paragraph focus, |
Contributor
Author
|
@Leemoonsoo : good point. thanks for pointing that out. it's changed to a now. |
Member
|
Thanks @MikeTYChen I'm merging it if there're no more discussions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
add a keyboard shortcut to add paragraph above to keep difference with previous add paragraph below
What type of PR is it?
Improvement
Todos
Is there a relevant Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-611
How should this be tested?
click into a paragraph and press ctrl+alt+n
Screenshots (if appropriate)
Questions: