Skip to content

Travis build fix#642

Closed
prabhjyotsingh wants to merge 2 commits intoapache:masterfrom
prabhjyotsingh:travisBuildFix
Closed

Travis build fix#642
prabhjyotsingh wants to merge 2 commits intoapache:masterfrom
prabhjyotsingh:travisBuildFix

Conversation

@prabhjyotsingh
Copy link
Copy Markdown
Contributor

@prabhjyotsingh prabhjyotsingh commented Jan 15, 2016

What is this PR for?

A lot of time travis fails with

Tests run: 11, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 4.77 sec <<< FAILURE! - in org.apache.zeppelin.notebook.NotebookTest
testSelectingReplImplementation(org.apache.zeppelin.notebook.NotebookTest)  Time elapsed: 0.025 sec  <<< ERROR!
org.apache.zeppelin.interpreter.InterpreterException: mock2 interpreter not found
    at org.apache.zeppelin.notebook.NoteInterpreterLoader.get(NoteInterpreterLoader.java:148)
    at org.apache.zeppelin.notebook.Note.run(Note.java:365)
    at org.apache.zeppelin.notebook.NotebookTest.testSelectingReplImplementation(NotebookTest.java:119)

.
.
.
.

Tests in error: 
  NotebookTest.testSelectingReplImplementation:119 » Interpreter mock2 interpret...

This is fix for that error, this doesn't happens always. But here is a lot when this failed last time. https://s3.amazonaws.com/archive.travis-ci.org/jobs/102172625/log.txt

What type of PR is it?

Improvement

Todos

  • - Clear registered interpreters after a test case is executed.

Is there a relevant Jira issue?

N/A

@Leemoonsoo
Copy link
Copy Markdown
Member

Leemoonsoo commented Jan 15, 2016

Thanks for the fix!
LGTM

@Leemoonsoo
Copy link
Copy Markdown
Member

Leemoonsoo commented Jan 15, 2016

Merge if there're no more discussions

@felixcheung
Copy link
Copy Markdown
Member

felixcheung commented Jan 16, 2016

looks good, good catch on the create dir

@asfgit asfgit closed this in cbfd869 Jan 16, 2016
@prabhjyotsingh prabhjyotsingh deleted the travisBuildFix branch January 18, 2016 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@prabhjyotsingh @Leemoonsoo @felixcheung