Skip to content

Update pom.xml#637

Closed
hash-X wants to merge 1 commit intoapache:masterfrom
hash-X:patch-2
Closed

Update pom.xml#637
hash-X wants to merge 1 commit intoapache:masterfrom
hash-X:patch-2

Conversation

@hash-X
Copy link
Copy Markdown

@hash-X hash-X commented Jan 14, 2016

What is this PR for?

improving pom.xml

What type of PR is it

Improvement

Todos

  • - Update pom.xml

Is there a relevant Jira issue?

May not require issue

How should this be tested?

I use mvn clean package -Pspark-1.4 -Phadoop-2.6 -DskipTests can cause the module Phoenix error and I think this should not appear. Reason about this issue is sqlline:sqlline:jar:1.1.8 is served from conjar repo. But sqlline:sqlline:jar:1.1.9 is served from maven repo. So add the dependency of sqlline1.1.9 can solve it. Of course, you can fix this issue by another way, but this way may be in common use.
http://mvnrepository.com/artifact/sqlline/sqlline/1.1.9

Screenshots (if appropriate)

Before
BUILD FAILURE

When you add this dependency
After

[INFO] Zeppelin: Apache Phoenix Interpreter ............... SUCCESS [  2.497 s]
[INFO] Zeppelin: PostgreSQL interpreter ................... SUCCESS [  0.572 s]
[INFO] Zeppelin: Tajo interpreter ......................... SUCCESS [  0.557 s]
[INFO] Zeppelin: Flink .................................... SUCCESS [  4.695 s]
[INFO] Zeppelin: Apache Ignite interpreter ................ SUCCESS [  0.536 s]
[INFO] Zeppelin: Kylin interpreter ........................ SUCCESS [  0.520 s]
[INFO] Zeppelin: Lens interpreter ......................... SUCCESS [  1.592 s]
[INFO] Zeppelin: Cassandra ................................ SUCCESS [ 35.948 s]
[INFO] Zeppelin: Elasticsearch interpreter ................ SUCCESS [  1.323 s]
[INFO] Zeppelin: web Application .......................... SUCCESS [ 52.998 s]
[INFO] Zeppelin: Server ................................... SUCCESS [ 11.377 s]
[INFO] Zeppelin: Packaging distribution ................... SUCCESS [  1.054 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 03:03 min
[INFO] Finished at: 2016-01-14T14:53:26+08:00
[INFO] Final Memory: 160M/1060M
[INFO] ------------------------------------------------------------------------

Questions:

  • Does the licenses files need update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? No

Update pom.xml
40f2eca 
I use mvn clean package -Pspark-1.4 -Phadoop-2.6 -DskipTests can cause error and I think this should not appear. Reason about this issue is sqlline:sqlline:jar:1.1.8 is served from conjar repo. But sqlline:sqlline:jar:1.1.9 is served from maven repo. So add the dependency of sqlline1.1.9 can solve it.
@gallenvara
Copy link
Copy Markdown

gallenvara commented Jan 14, 2016

Good to merge.

@Leemoonsoo
Copy link
Copy Markdown
Member

Leemoonsoo commented Jan 14, 2016

LGTM and merge if there're no more discussions.

@hash-X
Copy link
Copy Markdown
Author

hash-X commented Jan 15, 2016

@Leemoonsoo thanks for your review.

@asfgit asfgit closed this in 27163cb Jan 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hash-X @gallenvara @Leemoonsoo