Skip to content

fix logging to informative one#634

Closed
khalidhuseynov wants to merge 1 commit intoapache:masterfrom
khalidhuseynov:fix-logging
Closed

fix logging to informative one#634
khalidhuseynov wants to merge 1 commit intoapache:masterfrom
khalidhuseynov:fix-logging

Conversation

@khalidhuseynov
Copy link
Copy Markdown
Member

What is this PR for?

Improving logging information on error

What type of PR is it?

Fix/Improvement

Todos

  • - fix logging

Is there a relevant Jira issue?

May not require issue

How should this be tested?

Can be tested with any error for storage initialization
For example:

  1. in conf/zeppelin-env.sh add the following line
    export ZEPPELIN_NOTEBOOK_STORAGE="org.apache.zeppelin.notebook.repo.VFSNotebookRepo,org.apache.zeppelin.notebook.repo.DummyNotebookRepo"
  2. Start Zeppelin
  3. Previously you would see one line warning, now you would see more detailed trace-back as well.

Screenshots (if appropriate)

Before:

Failed to initialize com.nflabs.zeppelinhub.notebook.repo.DummyNotebookRepo notebook storage class java.lang.reflect.InvocationTargetException

After:

WARN [2016-01-13 22:43:05,557] ({main} NotebookRepoSync.java[<init>]:81) - Failed to initialize com.nflabs.zeppelinhub.notebook.repo.DummyNotebookRepo notebook storage class
java.lang.reflect.InvocationTargetException
    at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
    at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
    at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)

Questions:

  • Does the licenses files need update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? No

@felixcheung
Copy link
Copy Markdown
Member

looks good!

@bzz
Copy link
Copy Markdown
Member

bzz commented Jan 14, 2016

Looks good to me, will merge if the is no discussion

@asfgit asfgit closed this in 282cf27 Jan 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants