Restore Navbar connection status for websocket only#628
Closed
sejunra wants to merge 1 commit intoapache:masterfrom
sejunra:fix/NavbarConnectedStatus
Closed
Restore Navbar connection status for websocket only#628sejunra wants to merge 1 commit intoapache:masterfrom sejunra:fix/NavbarConnectedStatus
sejunra wants to merge 1 commit intoapache:masterfrom
sejunra:fix/NavbarConnectedStatus
Conversation
Contributor
|
Thanks, Tested, LGTM |
Member
|
LGTM. Thanks for the contribution. |
Contributor
|
Merging if there is no more discussions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
After the Shiro PR was merged, the Navbar status was changed to include the token status/name, however that part is reserved to show the Websocket status. Because of that it usually show a green circle with Disconnected next to it.
This PR sets the status to Websocket only.
What type of PR is it?
Bug Fix
Is there a relevant Jira issue?
No
How should this be tested?
You shouldn't see see Disconnected next to a green round in the navbar anymore
Screenshots (if appropriate)
Bug:
Questions: