Skip to content

Pass defaultValue parameter to z.select#623

Closed
corneadoug wants to merge 1 commit intoapache:masterfrom
corneadoug:fix/selectDisplayFormDefaultValue
Closed

Pass defaultValue parameter to z.select#623
corneadoug wants to merge 1 commit intoapache:masterfrom
corneadoug:fix/selectDisplayFormDefaultValue

Conversation

@corneadoug
Copy link
Copy Markdown
Contributor

What is this PR for?

This PR is to fix the z.select() defaultValue

What type of PR is it?

Bug Fix

Is there a relevant Jira issue?

https://issues.apache.org/jira/browse/ZEPPELIN-581

How should this be tested?

If you run:

val selected = z.select("formName", "option1", Seq(("option1", "option1DisplayName"), ("option2", "option2DisplayName")))
println(selected)

you should see: res27: Object = option1

Questions:

  • Does the licenses files need update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? No

@corneadoug
Copy link
Copy Markdown
Contributor Author

Triggering CI again

@corneadoug corneadoug closed this Jan 13, 2016
@corneadoug corneadoug reopened this Jan 13, 2016
@corneadoug
Copy link
Copy Markdown
Contributor Author

READY!

@Leemoonsoo
Copy link
Copy Markdown
Member

LGTM!

@corneadoug
Copy link
Copy Markdown
Contributor Author

Merging if there is no more discussion

@asfgit asfgit closed this in 11d25be Jan 13, 2016
@corneadoug corneadoug deleted the fix/selectDisplayFormDefaultValue branch August 24, 2016 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants