Skip to content

[Zeppelin 546](documentation) Enables interpreter library loading from maven repository#609

Closed
AhyoungRyu wants to merge 7 commits intoapache:masterfrom
AhyoungRyu:ZEPPELIN-546-docs
Closed

[Zeppelin 546](documentation) Enables interpreter library loading from maven repository#609
AhyoungRyu wants to merge 7 commits intoapache:masterfrom
AhyoungRyu:ZEPPELIN-546-docs

Conversation

@AhyoungRyu
Copy link
Copy Markdown
Contributor

What is this PR for?

This PR is related to #590. This documentation may explain the overall process of Dynamic Interpreter Loading in Helium Proposal.
Moreover, at the last this documentation, Zeppelin users can get the basic information about step by step of interpreter setting & configuring & binding. Since I assumed that they are novice at Zeppelin.

What type of PR is it?

Documentation

Todos

  • - Add docs image under /docs/assets/themes/zeppelin/img/docs-img/
  • - Add dynamicinterpreter.md
  • - Add dynamicinterpreter.html location to docs/_includes/themes/zeppelin/_navigation.html

Is there a relevant Jira issue?

  1. ZEPPELIN-533 Helium
  2. ZEPPELIN-546

How should this be tested?

I add a link of this documentation to interpreter tab in Zeppelin web page.
screen shot 2016-01-07 at 12 39 54 pm

Screenshots (if appropriate)

Hopefully, below image helps you to understand this process : )
zeppelin_user

Questions:

  • Does the licenses files need update? No.
  • Is there breaking changes for older versions? No.
  • Does this needs documentation? No.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

documentation

@AhyoungRyu
Copy link
Copy Markdown
Contributor Author

@felixcheung
Thank you for the review : )
I fixed them.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

straightforward

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@prabhjyotsingh Ashamed, I fixed it again : )

@felixcheung
Copy link
Copy Markdown
Member

looks good, nice graphic

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually this concept is come up with
-> This concept actually comes from

@AhyoungRyu
Copy link
Copy Markdown
Contributor Author

@corneadoug Thank you for your prudent review. I applied all of your comment in this docs : )

@corneadoug
Copy link
Copy Markdown
Contributor

Thanks, We can merge it when the other PR is merges :)

@corneadoug
Copy link
Copy Markdown
Contributor

Merging if theres no more discussions

@corneadoug
Copy link
Copy Markdown
Contributor

@AhyoungRyu Could you rebase your branch?

@felixcheung
Copy link
Copy Markdown
Member

@corneadoug it says no conflicts with the base?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants