[ZEPPELIN-559] Cassandra interpreter v2 by doanduyhai · Pull Request #600 · apache/zeppelin

doanduyhai · 2016-01-05T16:40:36Z

What is this PR for?

Update the Cassandra interpreter to V2 to support new schema commands to describe Cassandra 3.x features:
- User Defined Functions
- User Defined Aggregates
- Materialized Views
Add support for single line comment using double slashes (//)
Add DESCRIBE TYPES
The Java driver version is bumped to 3.0.0-rc1
The contextual HELP menu is also updated and a ChangeLog section is added.

What type of PR is it?

[Improvement]

Todos

- Add new PR to update official Cassandra interpreter with new features
- Test steps executed and confirmed working by the community
- Code review by the community (warning, Scala inside)

Is there a relevant Jira issue?

ZEPPELIN-559
ZEPPELIN-575 for doc

How should this be tested?

Download and install locally Cassandra 3.1.1
Start Cassandra
Clone this pull request locally with:
1. git fetch origin pull/600/head:CassandraInterpreterV2
2. git checkout CassandraInterpreterV2
Build this version of Zeppelin with mvn clean package -DskipTests
Start Zeppelin and update the property cassandra.hosts of the Cassandra interpreter (set it to localhost or 127.0.0.1 depending on your configuration)
In a paragraph, execute all the CQL statements given in this CassandraInterpreterV2TestData.cql by copy-pasting them
Start a new %cassandra paragraph and execute DESCRIBE FUNCTION test.maxOf;. You should be able to see:
Start a new %cassandra paragraph and execute DESCRIBE AGGREGATE test.group_by;. You should be able to see:
Start a new %cassandra paragraph and execute DESCRIBE MATERIALIZED VIEW test.user_by_country;. You should be able to see:
Start a new %cassandra paragraph and execute SELECT id,val1,val2,maxOf(val1,val2) FROM test.test_max;. You should be able to see:
Start a new %cassandra paragraph and execute SELECT group_by(category,sales_count) FROM test.items;. You should be able to see:
Start a new %cassandra paragraph and execute SELECT * FROM test.user_by_country WHERE country='FR';. You should be able to see:

Questions:

Does the licenses files need update? --> No
Is there breaking changes for older versions? --> No
Does this needs documentation? --> Yes

corneadoug · 2016-01-05T21:55:27Z

@doanduyhai thanks for the contribution, I know you gave some details in the JIRA issue, but could you update this PR description with our PR template? (https://github.com/apache/incubator-zeppelin/blob/master/CONTRIBUTING.md#creating-a-pull-request)

victorcouste · 2016-01-06T14:39:51Z

Just checked the full process, Cassandra interpreter v2 and new CQL scripts, all is ok

Leemoonsoo · 2016-01-07T22:07:50Z

@doanduyhai Great improvement! Somehow last commit didn't trigger CI. Could you trigger CI for last commit?

brianwawok · 2016-01-07T23:56:57Z

cassandra/src/test/scala/org/apache/zeppelin/cassandra/ParagraphParserTest.scala

Are these Options? A more idiomatic way to do this would be
parsed should be Some(List(DescribeFunctionCmd(None,"toto")))

Agree, will update the code to use more idiomatic Scala Option

doanduyhai · 2016-01-10T22:19:31Z

@corneadoug @Leemoonsoo

Code review has been done by @brianwawok and I pushed some refactoring.

The build succeeded but Travis marked it as failed because : The log length has exceeded the limit of 4 Megabytes (this usually means that test suite is raising the same exception over and over)

Looks like this is a very common issue with Travis, it is reported here: travis-ci/travis-ci#3865

doanduyhai · 2016-01-14T07:12:20Z

@Leemoonsoo @corneadoug Finally successful build

corneadoug · 2016-01-14T07:24:53Z

Those headers :)
I don't usually review interpreters, but I will test it out :)

Leemoonsoo · 2016-01-15T16:29:07Z

Thanks @doanduyhai for big improvement!
LGTM

felixcheung · 2016-01-20T05:46:53Z

LGTM. Any more comments or discussion on this PR?

Leemoonsoo · 2016-01-23T17:01:58Z

Merge if there're no more discussions

felixcheung · 2016-01-24T01:19:55Z

Tested, very nice interpreter thank you @doanduyhai !
A small amendment: to test this, make sure UDF sandbox is enabled in conf/cassandra.yaml
enable_user_defined_functions: true

Let's merge it

### What is this PR for? Update official documentation for **Cassandra interpreter V2** Related to PR: apache#600 ### What type of PR is it? [Documentation] ### Is there a relevant Jira issue? **[ZEPPELIN-575]** ### How should this be tested? Just check the doc after the build to see if you can see the **chapter 14 Change Log** ### Questions: * Does the licenses files need update? --> **No** * Is there breaking changes for older versions? --> **No** * Does this needs documentation? --> **No** [ZEPPELIN-575]: https://issues.apache.org/jira/browse/ZEPPELIN-575 Author: DuyHai DOAN <[email protected]> Closes apache#604 from doanduyhai/CassandraInterpreterDocumentation and squashes the following commits: d3f7871 [DuyHai DOAN] Use ZEPPELIN_VERSION variable instead of hard-coding c05d489 [DuyHai DOAN] Revert commit of doc cleaning PR apache#648 88811ee [DuyHai DOAN] Add Zeppelin version along-side with interpreter version 01716e1 [DuyHai DOAN] Cassandra Interpreter V2 doc e3dd18b [DuyHai DOAN] [ZEPPELIN-382] Add Documentation for Cassandra interpreter in the doc pages

### What is this PR for? Update official documentation for **Cassandra interpreter V2** Related to PR: #600 ### What type of PR is it? [Documentation] ### Is there a relevant Jira issue? **[ZEPPELIN-575]** ### How should this be tested? Just check the doc after the build to see if you can see the **chapter 14 Change Log** ### Questions: * Does the licenses files need update? --> **No** * Is there breaking changes for older versions? --> **No** * Does this needs documentation? --> **No** [ZEPPELIN-575]: https://issues.apache.org/jira/browse/ZEPPELIN-575 Author: DuyHai DOAN <[email protected]> Closes #604 from doanduyhai/CassandraInterpreterDocumentation and squashes the following commits: b1e70cb [DuyHai DOAN] Remove un-necessary whitespaces 80fcea4 [DuyHai DOAN] Add ZEPPELIN_VERSION in _config.yml f052bd8 [DuyHai DOAN] Fixes reference to ZEPPELIN_VERSION in markdown d3f7871 [DuyHai DOAN] Use ZEPPELIN_VERSION variable instead of hard-coding c05d489 [DuyHai DOAN] Revert commit of doc cleaning PR #648 88811ee [DuyHai DOAN] Add Zeppelin version along-side with interpreter version 01716e1 [DuyHai DOAN] Cassandra Interpreter V2 doc e3dd18b [DuyHai DOAN] [ZEPPELIN-382] Add Documentation for Cassandra interpreter in the doc pages

doanduyhai changed the title ~~Cassandra interpreter v2~~ [ZEPPELIN-559] Cassandra interpreter v2 Jan 5, 2016

doanduyhai force-pushed the CassandraInterpreter-V2 branch from 1ceb25d to 1fa7558 Compare January 5, 2016 17:40

doanduyhai mentioned this pull request Jan 6, 2016

[ZEPPELIN-575] Cassandra interpreter V2 documentation #604

Closed

brianwawok reviewed Jan 7, 2016
View reviewed changes

doanduyhai force-pushed the CassandraInterpreter-V2 branch 3 times, most recently from 6dd7a82 to 4342c0d Compare January 10, 2016 18:53

doanduyhai force-pushed the CassandraInterpreter-V2 branch 4 times, most recently from f8bfc03 to 06a9da5 Compare January 13, 2016 21:40

doanduyhai added 9 commits January 14, 2016 01:08

Upgrade Java driver version to 3.0.0-rc1

058161d

Add Support for UDF, UDA and Materialized Views

6b46076

Update help menu and changelog

6ea9e55

Update RegExp for UDF creation to fix multiple statements match

7a5ac39

Fix failing tests

6509da5

Fix CSS style for UDF & MV in menu display

138804c

Tune regular expression for FUNCTION creation pattern

41b8667

Refactor after code review

a2d831b

Fix random test failure

36e3bdb

doanduyhai force-pushed the CassandraInterpreter-V2 branch from 06a9da5 to 36e3bdb Compare January 14, 2016 00:08

asfgit closed this in 11a45e2 Jan 24, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ZEPPELIN-559] Cassandra interpreter v2#600

[ZEPPELIN-559] Cassandra interpreter v2#600
doanduyhai wants to merge 9 commits intoapache:masterfrom
doanduyhai:CassandraInterpreter-V2

doanduyhai commented Jan 5, 2016

Uh oh!

corneadoug commented Jan 5, 2016

Uh oh!

victorcouste commented Jan 6, 2016

Uh oh!

Leemoonsoo commented Jan 7, 2016

Uh oh!

brianwawok Jan 7, 2016

Uh oh!

doanduyhai Jan 8, 2016

Uh oh!

doanduyhai commented Jan 10, 2016

Uh oh!

doanduyhai commented Jan 14, 2016

Uh oh!

corneadoug commented Jan 14, 2016

Uh oh!

Leemoonsoo commented Jan 15, 2016

Uh oh!

felixcheung commented Jan 20, 2016

Uh oh!

Leemoonsoo commented Jan 23, 2016

Uh oh!

felixcheung commented Jan 24, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

doanduyhai commented Jan 5, 2016

What is this PR for?

What type of PR is it?

Todos

Is there a relevant Jira issue?

How should this be tested?

Questions:

Uh oh!

corneadoug commented Jan 5, 2016

Uh oh!

victorcouste commented Jan 6, 2016

Uh oh!

Leemoonsoo commented Jan 7, 2016

Uh oh!

brianwawok Jan 7, 2016

Choose a reason for hiding this comment

Uh oh!

doanduyhai Jan 8, 2016

Choose a reason for hiding this comment

Uh oh!

doanduyhai commented Jan 10, 2016

Uh oh!

doanduyhai commented Jan 14, 2016

Uh oh!

corneadoug commented Jan 14, 2016

Uh oh!

Leemoonsoo commented Jan 15, 2016

Uh oh!

felixcheung commented Jan 20, 2016

Uh oh!

Leemoonsoo commented Jan 23, 2016

Uh oh!

felixcheung commented Jan 24, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants