ZEPPELIN-544 ] After the restart when setting bug fixes interpreters note paragraphs state.#581
ZEPPELIN-544 ] After the restart when setting bug fixes interpreters note paragraphs state.#581cloverhearts wants to merge 2 commits intoapache:masterfrom cloverhearts:bug_fix/interpreter_restart_abort
Conversation
There was a problem hiding this comment.
It would be better to refactor setPropertyAndRestart() and restart() to remove duplication and prevent diverged issue like this.
There was a problem hiding this comment.
@HeartSaVioR Okay, I will attempt to code refactoring.
|
Great for finding missed spot! |
|
@HeartSaVioR Thank you for Feedback. have a nice day! |
|
Minor: How about extracting whole synchronized block to new private method? Actually setPropertyAndRestart() and restart() takes same logic except setting additional parameter and calling saveToFile(). setPropertyAndRestart() can call saveToFile() safely when new method is executed without InterpreterException. So new private method doesn't need to take care about safeToFile(). Next concern is that how we can unify logic whether two parameters are presented or not. |
|
@HeartSaVioR |
|
@cloverhearts OK, Don't worry. I'll address it to another issue. :) Happy new year! |
|
@HeartSaVioR Happy new year, HeartSaVioR! |
|
Forgot to say LGTM. :) |
|
LGTM and merge if there're no more discussions |
3 participants
What is this PR for?
Restful api - call upon the setting / interpreter id type,
The problem occurs in the status of running Paragraphs.
What type of PR is it?
Bug Fix
Todos
Is there a relevant Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-544
How should this be tested?
Paragraphs running after interpreter config change, save -> click okay on restart dialog
Screenshots (if appropriate)
before
after
Questions: