[ZEPPELIN-535] "Scheduler already terminated" occurs when RemoteInterpreter.close() doesn't succeed#574
[ZEPPELIN-535] "Scheduler already terminated" occurs when RemoteInterpreter.close() doesn't succeed#574Leemoonsoo wants to merge 2 commits intoapache:masterfrom
Conversation
|
Great for reducing complexity, modified code looks good to me. Related code block is here, Does this occur first time? Maybe we can't rely on sequence of interpreter setting now? |
b080ce6 to
9b7e8d5
Compare
|
@HeartSaVioR now ci is passing This PR make sure RemoteInterpreter.close() call InterpreterProcess.dereference(). |
|
@Leemoonsoo |
|
@HeartSaVioR Thanks for raising issue and taking review. |
|
@Leemoonsoo |
|
@HeartSaVioR It's not mandatory to have review from PPMC/committer since we follow lazy consensus rule but always good to be reviewed by more people including non-committer. |
|
According to CONTRIBUTING.md, a committer review is required, not one additional committer. So technically, nothing stops committer push self reviewed code. However, in Zeppelin project, committers used to initiate lazy consensus ("merge if there 're no more discussions") instead of pushing self reviewed code directly, when there're no review from other committers. |
|
@minahlee @Leemoonsoo |
|
@HeartSaVioR Thanks for asking. Please remember anyone can create a pullrequest to change CONTRIBUTING.md to improve review process, and more. |
What is this PR for?
Fix the exception "Scheduler already terminated" when remove interpreter close() fails
What type of PR is it?
Bug Fix
Is there a relevant Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-535
How should this be tested?
Modify any interpreter to throw exception on close() call.
And try to use it after restart the interpreter.
Screenshots (if appropriate)
Questions: