[ZEPPELIN-391] Keyboard shortcut#569
Closed
Leemoonsoo wants to merge 12 commits intoapache:masterfrom
Closed
Conversation
Member
Author
|
Please review
|
Member
|
Ctrl + c is commonly used to copy highlighted text to the clipboard so better to change. |
Member
Author
|
@minahlee You're right. Changed to Ctrl+Alt+c |
Member
|
Ctrl + Alt + k and Ctrl + Alt + E does work on chrome, firefox but not on IE |
Member
Author
|
@minahlee Some more shortcuts are not working in IE. for example Ctrl + n, Ctrl + p. |
Member
|
@Leemoonsoo sure |
Member
Author
|
I'll create an issue for shortcut on IE. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
This PR implements keyboard shortcuts for paragraph control.
What type of PR is it?
Feature
Is there a relevant Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-391
How should this be tested?
Try implemented shortcuts
Ctrl + Alt + c : Cancel run
Ctrl + Alt + d : Remove paragraph
Ctrl + Alt + k : Move paragraph Up
Ctrl + Alt + j : Move paragraph Down
Ctrl + Alt + b : Insert new paragraph below
Ctrl + Alt + o : Toggle output
Ctrl + Alt + e : Toggle editor
Ctrl + Alt + m : Toggle line numbers
Ctrl + Alt + t : Toggle title
Ctrl + Alt + 1
0,-,+ : Paragraph width from 112Questions: